Create PDF version for AbstractAlgebra#2307
Create PDF version for AbstractAlgebra#2307varuntrehan7 wants to merge 14 commits intoNemocas:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2307 +/- ##
==========================================
+ Coverage 88.00% 88.20% +0.19%
==========================================
Files 127 127
Lines 31803 32847 +1044
==========================================
+ Hits 27989 28973 +984
- Misses 3814 3874 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
okay got it, I was a bit stuck so was just trying things out( I will revert it ) and you are right I will post the error here if i cant resolve it, thanks! |
|
i tried to build it locally, heres the log error |
|
Is that the full .log file? |
|
AbstractAlgebra.jl.log |
|
I should add one clarification, With the original configuration (i.e. without warnonly = true), makedocs aborts earlier due to missing docstrings in several @docs blocks, so the LaTeX stage is never reached and no log file is produced. for example these - To be able to reach the LaTeX failure, I temporarily enabled warnonly = true locally only, which allowed Documenter to proceed far enough to generate the LaTeX output. |
|
I took the liberty of reformatting your comment using code block fences, i.e., triple backticks Those |
|
If I run this locally I get a quite different error in the log: So yeah, that won't work. We'd need a PDF version of that SVG. But just to see what happens, I remove the two lines referencing SVGs in With that hack, building the PDF succeeded |
|
I've merged PR #2324 to hopefully fix CI. |
oh thankyou i had no idea you can do that, i will do it next time and yes i am also getting them at master, i am running it locally using this - julia --project=docs -e 'include("docs/make.jl")'. |
|
The tests now run locally, if you still see problems locally then there is an issue with your setup. You write that you are doing That can work if the Manifest is up-to-date, and you have dev'ed AbstractAlgebra. What do you see when you do |
docs/make.jl
Outdated
| size_threshold_warn = 204800, | ||
| size_threshold = 409600, | ||
| ), | ||
| Documenter.LaTeX(), |
There was a problem hiding this comment.
We need a way to turn this off (or on): building the PDF is much slower than building HTML. So I want this off while I test the docs locally.
In Julia this is done in its doc/make.jl by checking:
# Check if we are building a PDF
const render_pdf = "pdf" in ARGS
and then use render_pdf to determine whether Documenter.LaTeX is included in the list of formats. Then you can run this to produce a PDF:
julia --project=docs docs/make.jl pdf
There was a problem hiding this comment.
While we are at it, it would also be nice if one could disable the doctests, e.g. by passing nodoctests or so, then it would set doctest=false
There was a problem hiding this comment.
okay I got it, thanks!
|
Please have a look at this @fingolfin , Also next should i do Nemo as we discussed before? |
.github/workflows/CI.yml
Outdated
| version: '1.10' | ||
| - uses: julia-actions/cache@v2 | ||
| - uses: julia-actions/julia-buildpkg@v1 | ||
| - name: Install TeX |
There was a problem hiding this comment.
| - name: Install TeX | |
| - name: Install TeX |
…tests` to skip doctests.
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
Continuing the job from oscar-system/Oscar.jl#5627.