Skip to content

Iván Aguilar - Movie recommendation solution #26

Open
Ivan01925 wants to merge 3 commits intoNearsoft:mainfrom
Ivan01925:main
Open

Iván Aguilar - Movie recommendation solution #26
Ivan01925 wants to merge 3 commits intoNearsoft:mainfrom
Ivan01925:main

Conversation

@Ivan01925
Copy link
Copy Markdown

@Ivan01925 Ivan01925 commented Apr 26, 2021

I finished the exercise, it passed all the tests, the solution reads the txt file and creates a cvs.

import org.apache.mahout.cf.taste.recommender.UserBasedRecommender;
import org.apache.mahout.cf.taste.similarity.UserSimilarity;

import java.io.*;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know the disadvantages of using wildcard imports? Why not use only what you need?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I corrected it, I was reading that it could lead to possible name conflicts and the readability of the code would decrease because the developers would not have a clear idea of the actual classes used.

//download movies.txt.gz from
// http://snap.stanford.edu/data/web-Movies.html
MovieRecommender recommender = new MovieRecommender("/path/to/movies.txt.gz");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are allowed to change how you read the recommender's data, but you are not allowed to add or make any other changes in the test file. Please remove recommender.convertFileToCSV(); and make sure to make the required changes so that your class still passes all tests.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, I removed it from the test file and modified the MovieRecommender, it still passed all the tests.

@jcordoba95
Copy link
Copy Markdown

Is there any specific reason why you'd commit and pushed the .idea/ folder? Why is it required for the project?

@Ivan01925
Copy link
Copy Markdown
Author

Is there any specific reason why you'd commit and pushed the .idea/ folder? Why is it required for the project?

Not really, it was a mistake, I already deleted it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants