feat: afterConfirmTx

[Tarnadas]

Introduces a new function afterConfirmTx for the VM to run a callback every time a tx has been confirmed.

Example BOS code from my chess game component:

afterConfirmTx((txConfirmations) => {
  console.log("afterConfirmTx", txConfirmations);
  for (const tx of txConfirmations) {
    const actions = tx?.transaction?.actions;
    if (Array.isArray(actions)) {
      for (const action of actions) {
        console.log("action", action);
        const methodName = action.FunctionCall?.method_name;
        console.log("methodName", methodName);
        if (!methodName) continue;
        if (
          methodName === "challenge" ||
          methodName === "accept_challenge" ||
          methodName === "reject_challenge"
        ) {
          // DO STUFF
        }
      }
    }
  }
});

2023-06-23.13-19-34.mp4

[evgenykuzyakov]

I think it's better to convert Near.call to return a promise instead of having a global callback.

[evgenykuzyakov]

Also please rebase from master to dev

[shelegdmitriy]

Hi @evgenykuzyakov! I'd like to participate in this PR but I wonder what is your vision this feature?

[petersalomonsen]

@Tarnadas How have you handled function access keys in order to avoid confirmation with the wallet? I'm into a similar thing with DevHub to solve this issue here: NEAR-DevHub/neardevhub-bos#137

I've solved access to multiple contracts by adding multiple keystores as you can see in the onging PR here ( there's a video in it): near/wallet-selector#887

But the remaining issue now is that in order to close the editor in DevHub, and also show Likes after transaction complete, a callback like you've created here is needed. It seems to me your PR will solve that part.

[Tarnadas]

Hey @petersalomonsen,
this is awesome and exactly what I would also need! I don't have any function access keys handling and users always need to confirm a tx, which is especially bad, if you're e.g. playing a game.

Yeah my PR would fix this. I wanted to get back to it and try to convert Near.call to return a promise, just like @evgenykuzyakov suggested, but I did not yet have the time.

[petersalomonsen]

Sounds good, but why return a Promise @evgenykuzyakov? A similar function like Social.set is also callback based and does not return a promise https://docs.near.org/bos/api/social#socialset.