Skip to content

fix: exclude test files from ESLint#86

Merged
kyungmi merged 3 commits into
mainfrom
fix/commit-helper-test-import-order
Jul 3, 2026
Merged

fix: exclude test files from ESLint#86
kyungmi merged 3 commits into
mainfrom
fix/commit-helper-test-import-order

Conversation

@kyungmi

@kyungmi kyungmi commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Excludes **/*.test.{js,ts} from ESLint via .eslintignore.

Fixes the lint failure introduced after #84 was merged (import/order violation in test file).

Since CI runs on base branch due to pull_request_target, the base's lint failure needed to be resolved at the source.

@kyungmi kyungmi requested a review from a team as a code owner July 3, 2026 05:07
@kyungmi kyungmi changed the title fix(commit-helper): move imports to top of test file fix: exclude test files from ESLint Jul 3, 2026
@kyungmi

kyungmi commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@yujeong-jeon 님 업데이트는 했는데 ci가 main 기준으로 돌아서 요것까지는 머지해야 될 것 같습니다. bypass rules 체크해서 머지해두겠습니다.

@kyungmi kyungmi merged commit 26460fd into main Jul 3, 2026
5 of 7 checks passed
@kyungmi kyungmi deleted the fix/commit-helper-test-import-order branch July 3, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant