🐛 fix: respect changesets fixed groups in canary publish#37
Merged
Conversation
protectUnchangedPackages marked every package without a changed file in the PR as private, ignoring the changesets `fixed` group. When a PR touched only one member of a fixed group, the others stayed unpublished and the released package pointed at versions that never shipped. Expand the publish set to include all members of any fixed group it intersects, so protection and version templating cover the whole group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
fixed그룹을 고려하지 않아 sibling 패키지 미배포 #36Type of Work
Description of Work
protectUnchangedPackagesmarked every package without a changed file in the PR as private, ignoring the changesetsfixedgroup. When a PR touched only one member of a fixed group, the others stayed unpublished and the released package pointed at versions that never shipped.Expand the publish set to include all members of any fixed group it intersects, so protection and version templating cover the whole group.
Review Points
Others