Skip to content

Allow power playback as a hercules_type#107

Open
paulf81 wants to merge 1 commit into
NatLabRockies:developfrom
paulf81:feature/power_playback
Open

Allow power playback as a hercules_type#107
paulf81 wants to merge 1 commit into
NatLabRockies:developfrom
paulf81:feature/power_playback

Conversation

@paulf81

@paulf81 paulf81 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Small change mostly allows a kind of pass-through controller for power playback type components in a Hercules simulation. These are presumed to be generators for now but we could revisit that. Needed this for one case study but happy to make sure more generally applicable.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request extends the Hercules v2 interface layer to recognize PowerPlayback components so they can participate in Hycon’s component-type classification (and be treated as generators for control/aggregation purposes) within Hercules-based simulations.

Changes:

  • Add PowerPlayback to the recognized Hercules component type lists.
  • Classify PowerPlayback components as type: "playback" with component_category: "generator" during HerculesInterface initialization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +80 to +81
elif c_type in hercules_playback_types:
self.plant_parameters[c] = {"type": "playback", "component_category": "generator"}
@misi9170

misi9170 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Is the idea that the power would be played back for just one of the components in a hybrid system? Is that why it's needed in Hycon rather than solely in Hercules?

@paulf81

paulf81 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

Is the idea that the power would be played back for just one of the components in a hybrid system? Is that why it's needed in Hycon rather than solely in Hercules?

Yeah that's right, if I try to combine say a battery component with power playback Hercules allows it but Hycon throws an error without this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants