Add progress bar to app_utils.download_file()#391
Open
aaronchantrill wants to merge 3 commits intoNaomiProject:naomi-devfrom
Open
Add progress bar to app_utils.download_file()#391aaronchantrill wants to merge 3 commits intoNaomiProject:naomi-devfrom
aaronchantrill wants to merge 3 commits intoNaomiProject:naomi-devfrom
Conversation
Add a progress bar to app_utils.download_file(url, local_filename) function. This is only really useful when using the command line client (we don't have another client right now) and only before the microphone feedback starts to display. It would be nice to move this into a visualization someday, but this is pretty tightly integrated with the operation itself. This commit also gives the download_file function the ability to resume partial downloads.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
naomi/app_utils.py appears to have been saved in dos eol format. This just updates the format to unix eol format for linux users. Windows users should have their line endings converted automatically when they clone the repository. Leaving the lines in dos eol format makes changes show up with ^M characters at the end when doing git diff. This commit is only changing the line endings in this one file.
Fixed a possibly uninitialized variable in naomi/app_utils.py. Also fixed a couple of flake8 complaints about inline comments without two spaces between the code and the hash symbol. Fixed an error that was causing the unittests to fail in diagnose.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a progress bar to app_utils.download_file(url, local_filename) function. This is only really useful when using the command line client (we don't have another client right now) and only before the microphone feedback starts to display. It would be nice to move this into a visualization someday, but this is pretty tightly integrated with the operation itself.
This commit also gives the download_file function the ability to resume partial downloads.
Related Issue
Standard functions with progress bars for downloads #303
Motivation and Context
If a large file needs to be downloaded, this gives the user a sense of how long the download will take.
How Has This Been Tested?
I have tested this function on a laptop computer and a Raspberry Pi 4 both running Debian Bookworm. I tested by installing the https://github.com/aaronchantrill/Naomi_VOSK_STT plugin and allowing it to download a model.
Screenshots (if appropriate):
Types of changes
Checklist: