Cleanup python/Makefile.am#3213
Merged
stevengj merged 1 commit intoNanoComp:masterfrom May 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four cleanups for
python/Makefile.am:WITH_MPBconditional blocks (lines 13-17 and 19-35).MPBPYTESTis defined in its own block for no reason - it can be merged into the second block, reducing 23 lines to ~15.$()vs.${}syntax - lines 61-62 use${DIFFRACTED_PLANEWAVE_TEST}and${DISPERSIVE_EIGENMODE_TEST}while every other variable reference uses$(). Both work in GNU Make, but mixing them is needless inconsistency.Q: Why is this not redundant...comment describes a confusion, not a constraint. Themeep:target on line 259 builds a localmeep/package tree for in-tree testing (soimport meepworks beforemake install), which is distinct from whatpkgpython_PYTHONdoes at install time. The comment is removed.