Modify skip condition for tests not involving MPI to include compile-time and runtime check#3209
Merged
oskooi merged 2 commits intoNanoComp:masterfrom Apr 28, 2026
Merged
Conversation
…time and runtime check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: The
test_mpiskip condition used intest_simulation.py(as well astest_dump_load.py) only checks the compile-time flagmp.with_mpi()(was Meep built with MPI?), but contains an assertion which requires a runtime condition (multiple MPI processes viampirun). When compiled with--with-mpi --with-openmpand run directly (e.g.,OMP_NUM_THREADS=2 python -m unittest, i.e., not as part ofmake checkwhich usesmpirun -np 2 python ...), the test is not skipped but the assertion fails becauseGet_size()returns 1 (nompirun).Fix: Add
mp.count_processors() < 2to the skip condition, so the test is skipped (not failed) when not runningmpirunwith multiple processes. Also switch frommp.comm.Get_size()tomp.count_processors()for consistency with the C++ API.