Skip to content

Make libGDSII an optional dependency #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevengj merged 3 commits into from
Apr 24, 2026
+11 −5
Merged

Make libGDSII an optional dependency #3207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d3aec3
Add guard for libGDSII to test_prism.py
oskooi Apr 24, 2026
2001386
add AM_CONDITONAL statement for libGDSII to configure.ac
oskooi Apr 24, 2026
dfb201a
make gdsII-3D an optional test
oskooi Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,7 @@ if test "x$have_gdsii" = xmaybe; then
AC_MSG_RESULT($have_gdsii_getlayers)
fi
fi
AM_CONDITIONAL(WITH_LIBGDSII, test "x$ac_cv_lib_GDSII_libGDSIIExists" = "xyes")

##############################################################################
# The following function is used only for debugging. Note that
Expand Down
9 changes: 5 additions & 4 deletions python/tests/test_prism.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,11 @@ def bigtest_prism(self):
self.assertAlmostEqual(d_nosym[1], d_sym[1], places=3)
self.assertAlmostEqual(d_nosym[2], d_sym[2], places=3)

print("Testing Non-Convex Prism from GDSII file...")
d = self.spiral_gds()
d_ref = 455.01744881372224
self.assertAlmostEqual(d, d_ref, places=5)
if mp.with_libGDSII():
print("Testing Non-Convex Prism from GDSII file...")
d = self.spiral_gds()
d_ref = 455.01744881372224
self.assertAlmostEqual(d, d_ref, places=5)

def test_prism(self):
print("Testing Non-Convex Prism #3 using marching squares algorithm...")
Expand Down
6 changes: 5 additions & 1 deletion tests/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ AM_CPPFLAGS = -I$(top_srcdir)/src -DDATADIR=\"$(srcdir)/\"

.SUFFIXES = .dac .done

check_PROGRAMS = aniso_disp bench bragg_transmission convergence_cyl_waveguide cylindrical dump_load flux harmonics integrate known_results near2far one_dimensional physical stress_tensor symmetry three_d two_dimensional 2D_convergence h5test pml pw-source-ll ring-ll cyl-ellipsoid-ll absorber-1d-ll array-slice-ll user-defined-material dft-fields gdsII-3d bend-flux-ll array-metadata
check_PROGRAMS = aniso_disp bench bragg_transmission convergence_cyl_waveguide cylindrical dump_load flux harmonics integrate known_results near2far one_dimensional physical stress_tensor symmetry three_d two_dimensional 2D_convergence h5test pml pw-source-ll ring-ll cyl-ellipsoid-ll absorber-1d-ll array-slice-ll user-defined-material dft-fields bend-flux-ll array-metadata

if WITH_LIBGDSII
check_PROGRAMS += gdsII-3d
endif

array_metadata_SOURCES = array-metadata.cpp
array_metadata_LDADD = $(MEEPLIBS)
Expand Down
Loading