Skip to content

Exclude tests involving adjoint solver from make check#3181

Merged
stevengj merged 4 commits intoNanoComp:masterfrom
oskooi:make_check_exclude_adjoint
May 8, 2026
Merged

Exclude tests involving adjoint solver from make check#3181
stevengj merged 4 commits intoNanoComp:masterfrom
oskooi:make_check_exclude_adjoint

Conversation

@oskooi
Copy link
Copy Markdown
Collaborator

@oskooi oskooi commented Mar 26, 2026

The four tests involving the adjoint solver (particularly test_adjoint_solver.py) take an unusually long time to complete which tends to slow down the CI. This PR modifies make check to exclude these tests and instead creates a make check-adjoint whicn can be used to run all tests (including those involving the adjoint solver).

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.65%. Comparing base (f29a8c7) to head (34cdcde).
⚠️ Report is 117 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (f29a8c7) and HEAD (34cdcde). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (f29a8c7) HEAD (34cdcde)
5 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3181       +/-   ##
===========================================
- Coverage   73.81%   63.65%   -10.16%     
===========================================
  Files          18       18               
  Lines        5423     5454       +31     
===========================================
- Hits         4003     3472      -531     
- Misses       1420     1982      +562     

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj
Copy link
Copy Markdown
Collaborator

stevengj commented Apr 3, 2026

Is there a way to conditionally run this?

And/or run it periodically or upon a trigger?

@stevengj
Copy link
Copy Markdown
Collaborator

stevengj commented Apr 3, 2026

Maybe add a workflow for a new action to run make check-adjoint periodically (e.g. once a week), which we can also trigger manually.

@oskooi
Copy link
Copy Markdown
Collaborator Author

oskooi commented May 2, 2026

A separate GitHub Actions workflow for make check-adjoint (adjoint tests only) has been added which runs once every week (Sundays at 10 pm). make check involves only the non-adjoint tests.

@oskooi oskooi force-pushed the make_check_exclude_adjoint branch from 349ab78 to deb672c Compare May 4, 2026 04:03
@stevengj
Copy link
Copy Markdown
Collaborator

stevengj commented May 8, 2026

It looks like there is a way to set up the adjoint tests to run on PRs on manual request by triggering by a label?

https://stackoverflow.com/questions/62325286/run-github-actions-when-pull-requests-have-a-specific-label

@stevengj stevengj merged commit ac1c675 into NanoComp:master May 8, 2026
5 checks passed
@oskooi oskooi deleted the make_check_exclude_adjoint branch May 8, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants