feat: add fee-bump, sponsorship, and clawback operations to transaction builder (#196)#232
Merged
Nanle-code merged 1 commit intoMay 30, 2026
Conversation
|
@Amas-01 is attempting to deploy a commit to the nanle-code's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Amas-01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #196
Summary
✅ Implementation Complete: Fee-Bump, Sponsorship, and Clawback Operations (#196)
Successfully implemented fee-bump wrappers, begin/end sponsorship operations, and clawback operations in the Stellar Transaction Builder. All changes follow codebase patterns, include comprehensive validation, UI forms, and test coverage.
Stellar SDK Version
[@stellar/stellar-sdk@^12.3.0]confirmed from[package.json]All API signatures verified against this version's documentation
Files Modified (8 files, 973+ lines added)
[transactionBuilder.js][feeBump]to[OPERATION_TYPES]array[clawback]to[OPERATION_TYPES]array[feeBump(params)]function — wraps inner transaction XDR with higher fee[clawback]case in[createOperation()]— builds Clawback operationNo new dependencies, no hardcoded credentials
[transactionValidation.ts][validateFeeBump()]— validates feeSource, baseFee, innerTransaction[validateClawback()]— validates assetCode, assetIssuer, from, amount[validateEndSponsoring()]— zero-parameter validation[validateOperation()]switch to handle all 4 new typesFollows exact pattern of existing validators
[TransactionBuilder.jsx][renderOperationFields()]for all 4 operation types[useMemo]hook for all 4 operationsReuses existing components, follows existing styling patterns
[Builder.jsx][feeBump]to[OPERATION_TYPES]array[addOperation()]to initialize feeBump params[getTypeLabel()]switch for feeBump[OperationCard]componentBuilder already had sponsorship and clawback support
[transactionBuilder.md][feeBump(params)]section with full documentation[clawback]operation section with asset issuer requirements[beginSponsoringFutureReserves]section[endSponsoringFutureReserves]sectionFollows existing documentation format
[TRANSACTION_BUILDER_ENHANCEMENT.md]Clawback requires issuer authority
Sponsorship operations must be paired
No hardcoded network passphrases
✅ Added acceptance criteria confirmation
Comprehensive enhancement documentation
[transactionBuilder.feeBumpClawback.test.js](NEW)Builder unit tests (6): feeBump envelope building, error handling, sponsorship operations, clawback operations
Validation tests (5): feeBump schema, beginSponsoring, clawback validation
Operation type tests (5): All four operations in OPERATION_TYPES array
~90% code coverage on new functions