Skip to content

feat(a11y): axe-core CI regression + critical violation fixes (#204)#227

Merged
Nanle-code merged 1 commit into
Nanle-code:masterfrom
jabir-dev788:feat/accessibility-ci-axe-wcag
May 29, 2026
Merged

feat(a11y): axe-core CI regression + critical violation fixes (#204)#227
Nanle-code merged 1 commit into
Nanle-code:masterfrom
jabir-dev788:feat/accessibility-ci-axe-wcag

Conversation

@jabir-dev788
Copy link
Copy Markdown
Contributor

Summary

Resolves #204. Adds automated accessibility regression via @axe-core/playwright
and fixes the two named critical violations.

Changes by file

File Change
package.json Add @axe-core/playwright devDependency
tests/e2e/navigation.spec.js 3 new axe scan tests for connect/overview/notifications
.github/workflows/accessibility.yml Install Playwright browsers + run E2E axe tests
src/App.tsx aria-label="Notifications" on NotificationBell button
src/components/dashboard/ConnectPanel.jsx Call announceToScreenReader() on connect success
docs/contributing.md Manual WCAG checklist section

Acceptance criteria verified

  • accessibility.yml fails on serious/critical violations
  • ScreenReaderAnnouncer receives announcement on connect success
  • NotificationBell button has accessible name

- Add @axe-core/playwright to E2E suite for connect/navigation flows
- accessibility.yml fails on serious/critical axe violations
- Add aria-label to NotificationBell button in App
- Wire announceToScreenReader() to connect success in ConnectPanel
- Add WCAG manual checklist to docs/contributing.md

Closes Nanle-code#204
@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

@jabir-dev788 is attempting to deploy a commit to the nanle-code's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 29, 2026

@jabir-dev788 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@jabir-dev788
Copy link
Copy Markdown
Contributor Author

Hi! This PR implements issue #204 — axe-core accessibility CI scans
with WCAG regression for the connect → overview → transactions flow,
plus the NotificationBell aria-label fix and ScreenReaderAnnouncer
wiring on connect success.

Changes are scoped to the 6 files listed in the issue. Could you
approve the workflow run when you get a chance? Happy to address
any feedback. Thanks!

@Nanle-code Nanle-code merged commit 2b4aa29 into Nanle-code:master May 29, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility CI: axe-core scans + WCAG checklist for core flows

2 participants