Skip to content

Refactor image request management#73

Merged
NachoSoto merged 7 commits intomasterfrom
fix-asyncswiftuiimageview-constructor-logic-2025-12-01
Dec 1, 2025
Merged

Refactor image request management#73
NachoSoto merged 7 commits intomasterfrom
fix-asyncswiftuiimageview-constructor-logic-2025-12-01

Conversation

@NachoSoto
Copy link
Copy Markdown
Owner

Summary

  • move the request signal wiring for AsyncSwiftUIImageView into a dedicated observable view model to avoid re-creating the pipe during view initialization
  • update the SwiftUI view to own the view model via @StateObject, react to its published render result, and reuse the scheduler-based request helper

Testing

  • swiftlint --config .swiftlint.yml --strict

Codex Task

Copy link
Copy Markdown
Owner Author

@NachoSoto NachoSoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@NachoSoto NachoSoto merged commit ed3f482 into master Dec 1, 2025
1 check passed
@NachoSoto NachoSoto deleted the fix-asyncswiftuiimageview-constructor-logic-2025-12-01 branch December 1, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant