Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| "commitish" : "8581f24e9944521975a1b2177a7bb9b95ab803ed", | ||
| "tvOS" : [ | ||
| { | ||
| "name" : "ReactiveSwift", |
There was a problem hiding this comment.
Removing vendored Carthage frameworks breaks Example target
This commit deletes the checked-in Carthage build artifacts for ReactiveSwift (and the associated XCFrameworks), but the Example Xcode project still hard-codes framework references and input paths under $(SRCROOT)/Carthage/Build/iOS for ReactiveCocoa/ReactiveSwift/Result/AsyncImageView. Without those binaries present, the Example target can no longer build or run unless users manually rerun Carthage to recreate the missing frameworks, which is a regression from the previous out-of-the-box state.
Useful? React with 👍 / 👎.
No description provided.