Skip to content

Delete Carthage#66

Merged
NachoSoto merged 1 commit intomasterfrom
NachoSoto-patch-1
Nov 30, 2025
Merged

Delete Carthage#66
NachoSoto merged 1 commit intomasterfrom
NachoSoto-patch-1

Conversation

@NachoSoto
Copy link
Copy Markdown
Owner

No description provided.

@NachoSoto NachoSoto enabled auto-merge (squash) November 30, 2025 04:30
@NachoSoto NachoSoto merged commit 90b0010 into master Nov 30, 2025
1 check passed
@NachoSoto NachoSoto deleted the NachoSoto-patch-1 branch November 30, 2025 04:34
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines -1 to -5
{
"commitish" : "8581f24e9944521975a1b2177a7bb9b95ab803ed",
"tvOS" : [
{
"name" : "ReactiveSwift",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Removing vendored Carthage frameworks breaks Example target

This commit deletes the checked-in Carthage build artifacts for ReactiveSwift (and the associated XCFrameworks), but the Example Xcode project still hard-codes framework references and input paths under $(SRCROOT)/Carthage/Build/iOS for ReactiveCocoa/ReactiveSwift/Result/AsyncImageView. Without those binaries present, the Example target can no longer build or run unless users manually rerun Carthage to recreate the missing frameworks, which is a regression from the previous out-of-the-box state.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant