Skip to content

Fix test warnings#64

Merged
NachoSoto merged 15 commits intomasterfrom
codex/fix-build-warnings-in-tests
Nov 30, 2025
Merged

Fix test warnings#64
NachoSoto merged 15 commits intomasterfrom
codex/fix-build-warnings-in-tests

Conversation

@NachoSoto
Copy link
Copy Markdown
Owner

Summary

  • add the @retroactive attribute to the test-only retroactive conformances so the compiler no longer warns about possible collisions with the standard library
  • remove the redundant try? wrappers in MulticastedRendererSpec so Swift no longer emits “no calls to throwing functions” warnings during the build

Testing

  • swift test (fails: the sandbox toolchain does not ship the Combine framework, so SwiftPM cannot import it when compiling AsyncImageLoader.swift)

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Base automatically changed from codex/add-github-workflow-for-build-and-test to master November 30, 2025 03:48
@NachoSoto NachoSoto enabled auto-merge (squash) November 30, 2025 04:06
@NachoSoto NachoSoto merged commit ee5cde9 into master Nov 30, 2025
1 check passed
@NachoSoto NachoSoto deleted the codex/fix-build-warnings-in-tests branch November 30, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant