Open
Conversation
Signed-off-by: Alexis Girault <agirault@nvidia.com>
- 10.0 is from CTK 12.8+ - 10.1 was missing Signed-off-by: Alexis Girault <agirault@nvidia.com>
The list was the same Signed-off-by: Alexis Girault <agirault@nvidia.com>
Signed-off-by: Alexis Girault <agirault@nvidia.com>
drossetti
reviewed
Apr 3, 2025
| COMPUTE_LIST="$COMPUTE_LIST 120" | ||
| SM_LIST="$SM_LIST 120" | ||
| # Add Blackwell (10.0, 10.1, 12.0) if CUDA >= 12.8 | ||
| if [ "$CUDA_VERSION_MAJOR" -ge 12 ] && [ "$CUDA_VERSION_MINOR" -ge 8 ]; then |
Member
There was a problem hiding this comment.
does this check work for CUDA 13.0?
| fi | ||
|
|
||
| # Add Ada Lovelace (8.9) if CUDA >= 11.8 | ||
| if [ "$CUDA_VERSION_MAJOR" -ge 11 ] && [ "$CUDA_VERSION_MINOR" -ge 8 ]; then |
Author
There was a problem hiding this comment.
I doubt it would. wasn't in the scope of this MR but I can edit these checks to check major first
Collaborator
|
@agirault The fix has been merged to R2.5 branch (https://github.com/NVIDIA/gdrcopy/tree/R2.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changes
nvcc --list-gpu-codedirectly when available