-
Notifications
You must be signed in to change notification settings - Fork 241
cuda.core.system: Better checks for when we expect APIs to be unsupported #1510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdboom
wants to merge
11
commits into
NVIDIA:main
Choose a base branch
from
mdboom:cuda.core.system-better-compat-check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2df0c31
cuda.core.system: Better checks for when we expect APIs to be unsuppo…
mdboom 70a252d
Update cuda_core/tests/system/test_system_device.py
mdboom a9d074b
Update cuda_core/tests/system/conftest.py
mdboom c56e49b
Update cuda_bindings/tests/nvml/conftest.py
mdboom 0808139
Fix importing of conftest.py
mdboom 9b571b4
Fix tests
mdboom 032c4e6
Fix tests
mdboom 9c815cc
Fix a test on T4
mdboom 04cf332
Refactor test helper
mdboom 0545f4b
Use Unicode character
mdboom b97f3c8
Fix imports
mdboom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: LicenseRef-NVIDIA-SOFTWARE-LICENSE | ||
|
|
||
|
|
||
| # This package contains test helper utilities that may also be useful for other libraries outside of `cuda.bindings`, | ||
| # such as `cuda.core`. These utilities are not part of the public API of `cuda.bindings` and may change without notice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: LicenseRef-NVIDIA-SOFTWARE-LICENSE | ||
|
|
||
|
|
||
| from contextlib import contextmanager | ||
|
|
||
| import pytest | ||
| from cuda.bindings import _nvml as nvml | ||
|
|
||
|
|
||
| @contextmanager | ||
| def unsupported_before(device: int, expected_device_arch: nvml.DeviceArch | str | None): | ||
| device_arch = nvml.device_get_architecture(device) | ||
|
|
||
| if isinstance(expected_device_arch, nvml.DeviceArch): | ||
| expected_device_arch_int = int(expected_device_arch) | ||
| elif expected_device_arch == "FERMI": | ||
| expected_device_arch_int = 1 | ||
| else: | ||
| expected_device_arch_int = 0 | ||
|
|
||
| if expected_device_arch is None or expected_device_arch == "HAS_INFOROM" or device_arch == nvml.DeviceArch.UNKNOWN: | ||
| # In this case, we don't /know/ if it will fail, but we are ok if it | ||
| # does or does not. | ||
|
|
||
| # TODO: There are APIs that are documented as supported only if the | ||
| # device has an InfoROM, but I couldn't find a way to detect that. For | ||
| # now, they are just handled as "possibly failing". | ||
|
|
||
| try: | ||
| yield | ||
| except nvml.NotSupportedError: | ||
| pytest.skip( | ||
| f"Unsupported call for device architecture {nvml.DeviceArch(device_arch).name} " | ||
| f"on device '{nvml.device_get_name(device)}'" | ||
| ) | ||
| elif int(device_arch) < expected_device_arch_int: | ||
| # In this case, we /know/ if will fail, and we want to assert that it does. | ||
| with pytest.raises(nvml.NotSupportedError): | ||
| yield | ||
| pytest.skip(f"Unsupported before {expected_device_arch.name}, got {nvml.device_get_name(device)}") | ||
| else: | ||
| # In this case, we /know/ it should work, and if it fails, the test should fail. | ||
| yield |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.