Skip to content

Extract modeling tests into a common extendable test suite#1445

Draft
pstjohn wants to merge 5 commits intoNVIDIA:mainfrom
pstjohn:pstjohn/bio-154-extract-modeling-test-suite-into-a-common-importable
Draft

Extract modeling tests into a common extendable test suite#1445
pstjohn wants to merge 5 commits intoNVIDIA:mainfrom
pstjohn:pstjohn/bio-154-extract-modeling-test-suite-into-a-common-importable

Conversation

@pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Feb 4, 2026

We currently have a lot of duplication in model tests, which makes adding new models harder than it should be (and means that we may be missing some test coverage between models). We can copy transformers and have a TestClass base class that we extend for each model that runs each through a common battery of tests.

Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 4, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@pstjohn pstjohn force-pushed the pstjohn/bio-154-extract-modeling-test-suite-into-a-common-importable branch from 7c99b7b to beac745 Compare February 4, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant