chore(recipes): fix stale kgateway-crds path in slinky-slurm-operator-crds comment#887
Merged
mchmarny merged 1 commit intoMay 14, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA comment in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
3fee0bd to
1bff534
Compare
mchmarny
approved these changes
May 14, 2026
…-crds comment The slinky-slurm-operator-crds values file's comment references `components/kgateway-crds/values.yaml` as an example of the "AICR umbrella convention for CRD-only components." That path no longer exists — the kgateway component was renamed to agentgateway in NVIDIA#871, and the file is now at `components/agentgateway-crds/ values.yaml`. One-line comment fix; no behavior change. Surfaced during a post-NVIDIA#871 audit for residual kgateway references in active code paths.
1bff534 to
b5d7bcc
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line comment fix.
recipes/components/slinky-slurm-operator-crds/values.yaml:23referencescomponents/kgateway-crds/values.yamlas an example of the "AICR umbrella convention for CRD-only components." That path no longer exists — the kgateway component was renamed to agentgateway in #871, and the file is now atcomponents/agentgateway-crds/values.yaml.Motivation / Context
Surfaced during a post-#871 audit for residual kgateway references in active code paths. The conformance validator, chainsaw assertions, and evidence collection script were all fully updated in #871; this stale cross-reference comment was the only actionable residual that would mislead future maintainers (the other surviving kgateway references are intentional historical context — frozen conformance snapshots, the changelog, etc.).
Related: #871 (kgateway → agentgateway migration), #866 (slinky-slurm-operator component addition)
Type of Change
Component(s) Affected
recipes/components/slinky-slurm-operator-crds/values.yaml— comment only)Implementation Notes
No behavior change, no Helm value semantics affected.
Testing
make lint # passes (yamllint, license headers, agents-sync, chart-pin verification)Comment-only YAML change; full
make qualifynot necessary.Risk Assessment
Rollout notes: None — comment-only.
Checklist
make lint)make lint)git commit -S)