Skip to content

chore(recipes): fix stale kgateway-crds path in slinky-slurm-operator-crds comment#887

Merged
mchmarny merged 1 commit into
NVIDIA:mainfrom
yuanchen8911:chore/fix-stale-kgateway-comment
May 14, 2026
Merged

chore(recipes): fix stale kgateway-crds path in slinky-slurm-operator-crds comment#887
mchmarny merged 1 commit into
NVIDIA:mainfrom
yuanchen8911:chore/fix-stale-kgateway-comment

Conversation

@yuanchen8911
Copy link
Copy Markdown
Contributor

Summary

One-line comment fix. recipes/components/slinky-slurm-operator-crds/values.yaml:23 references components/kgateway-crds/values.yaml as an example of the "AICR umbrella convention for CRD-only components." That path no longer exists — the kgateway component was renamed to agentgateway in #871, and the file is now at components/agentgateway-crds/values.yaml.

Motivation / Context

Surfaced during a post-#871 audit for residual kgateway references in active code paths. The conformance validator, chainsaw assertions, and evidence collection script were all fully updated in #871; this stale cross-reference comment was the only actionable residual that would mislead future maintainers (the other surviving kgateway references are intentional historical context — frozen conformance snapshots, the changelog, etc.).

Related: #871 (kgateway → agentgateway migration), #866 (slinky-slurm-operator component addition)

Type of Change

  • Documentation update (comment-only)

Component(s) Affected

  • Recipe engine / data (recipes/components/slinky-slurm-operator-crds/values.yaml — comment only)

Implementation Notes

- # components/kgateway-crds/values.yaml). It is consumed by the AICR
+ # components/agentgateway-crds/values.yaml). It is consumed by the AICR

No behavior change, no Helm value semantics affected.

Testing

make lint   # passes (yamllint, license headers, agents-sync, chart-pin verification)

Comment-only YAML change; full make qualify not necessary.

Risk Assessment

  • Low — Pure comment fix. No code, no chart pins, no values semantics affected.

Rollout notes: None — comment-only.

Checklist

  • Tests pass locally (make lint)
  • Linter passes (make lint)
  • I did not skip/disable tests to make CI green
  • I added/updated tests for new functionality (n/a — comment-only)
  • I updated docs if user-facing behavior changed (n/a — internal comment)
  • Changes follow existing patterns in the codebase
  • Commits are cryptographically signed (git commit -S)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: bcc26e5c-269f-4c6a-8c81-95f28ab61dba

📥 Commits

Reviewing files that changed from the base of the PR and between 1bff534 and b5d7bcc.

📒 Files selected for processing (1)
  • recipes/components/slinky-slurm-operator-crds/values.yaml

📝 Walkthrough

Walkthrough

A comment in recipes/components/slinky-slurm-operator-crds/values.yaml was corrected to reference the upstream CRD-only component path as components/agentgateway-crds/values.yaml instead of the incorrect components/kgateway-crds/values.yaml. The chart configuration and enabled: true setting remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: fixing a stale reference to kgateway-crds in a comment within the slinky-slurm-operator-crds values file.
Description check ✅ Passed The description provides relevant context about the change, explaining why the kgateway reference became stale after the #871 migration and how it was discovered during the post-migration audit.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@yuanchen8911 yuanchen8911 force-pushed the chore/fix-stale-kgateway-comment branch 2 times, most recently from 3fee0bd to 1bff534 Compare May 14, 2026 18:51
@mchmarny mchmarny enabled auto-merge (squash) May 14, 2026 18:52
…-crds comment

The slinky-slurm-operator-crds values file's comment references
`components/kgateway-crds/values.yaml` as an example of the
"AICR umbrella convention for CRD-only components." That path no
longer exists — the kgateway component was renamed to agentgateway
in NVIDIA#871, and the file is now at `components/agentgateway-crds/
values.yaml`.

One-line comment fix; no behavior change.

Surfaced during a post-NVIDIA#871 audit for residual kgateway references in
active code paths.
@yuanchen8911 yuanchen8911 force-pushed the chore/fix-stale-kgateway-comment branch from 1bff534 to b5d7bcc Compare May 14, 2026 19:10
@mchmarny mchmarny merged commit dc55455 into NVIDIA:main May 14, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants