chore(recipes): align overlay network-operator pins to v26.1.1#886
Merged
mchmarny merged 2 commits intoMay 14, 2026
Conversation
`recipes/registry.yaml` already pins network-operator at `26.1.1`, but two overlays carry their own explicit pins that drift from the default: - recipes/overlays/kind.yaml: 25.1.0 → 26.1.1 (was a year behind; this is the `25.1.0 → v26.1.1` bump that NVIDIA#698's audit flagged) - recipes/overlays/aks.yaml: "v26.1.0" → "26.1.1" (also drops the spurious "v" prefix — NGC's chart version is "26.1.1" without "v"; Helm was emitting a warning on every render: "unable to find exact version requested; falling back to closest available version") No image changes — verified by `make bom-docs` producing zero diff against main, since the registry default at 26.1.1 was already the BOM source. This PR is purely overlay-consistency cleanup so the explicit pins match what bundles built from the registry default already use. Pre-existing dead config noted (not addressed here, follow-up): `recipes/components/network-operator/values.yaml` carries top-level keys (`deployCR`, `nicClusterPolicy`, `nvIpam`, `secondaryNetwork`) that the v26.1.x chart schema no longer accepts. Helm silently ignores them. The chart renders correctly; the keys are simply dead config. Cleaning up the kind values file to match the new schema is out of scope for this chart-pin alignment. Closes follow-up NVIDIA#3 from issue NVIDIA#698. Validation: - `make qualify`: all Go unit tests pass with race detector, 20/20 chainsaw tests pass, golangci-lint + yamllint clean, vulnerability scan + license headers OK - `make bom-docs`: regenerated docs/user/container-images.md; zero diff vs main (registry default unchanged) - `helm template` against the v26.1.1 chart with both AICR values files renders without errors
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mchmarny
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns two overlay-level
network-operatorchart pins to match the registry default (26.1.1):recipes/overlays/kind.yaml:25.1.0 → 26.1.1(a year behind — this is the25.1.0 → v26.1.1major bump chore(recipes): check and update runtime component versions across all recipes #698's audit flagged)recipes/overlays/aks.yaml:"v26.1.0" → "26.1.1"(also drops the spurious"v"prefix — NGC publishes the chart as26.1.1withoutv; Helm was warning"unable to find exact version requested; falling back to closest available version"on every render)Motivation / Context
The audit in #698 lists
network-operator: 25.1.0 → v26.1.1, major. The registry default atrecipes/registry.yamlwas bumped to26.1.1in #777, but two overlays carry their own explicit pins that didn't get updated alongside the registry — the classic overlay-pin drift pattern we've cleaned up in dynamo (#725) and aws-efa (#872).Fixes: follow-up #3 from #698 (
network-operator: 25.1.0 → v26.1.1, major)Related: #698, #777 (registry default bump)
Type of Change
Component(s) Affected
recipes/overlays/kind.yaml,recipes/overlays/aks.yaml)Implementation Notes
No image changes.
make bom-docsproduces zero diff against main after this PR, because the registry default at26.1.1was already the BOM source — every bundle built from the registry default has been using v26.1.1 since #777. The two overlays were the only places still pinning older versions, and the kind overlay's25.1.0pin was a year stale.v-prefix correction on aks.yaml. NGC publishes the chart as version
26.1.1(novprefix; theappVersionisv26.1.1). The"v26.1.0"pin in aks.yaml was emittingWARN: unable to find exact version requested; falling back to closest available versionon every render. Helm was falling back to chart26.1.0correctly, but the warning is noisy and the pin should match the chart version exactly.Dead config in kind values.yaml (noted, not addressed).
recipes/components/network-operator/values.yamlcarries top-level keys (deployCR,nicClusterPolicy,nvIpam,secondaryNetwork) that the v26.1.x chart schema no longer accepts. Helm silently ignores them and the chart renders correctly; the keys are simply dead config. Cleaning up the kind values file to match the new schema is out of scope for this chart-pin alignment — would conflate "bump pin" with "rewrite values schema" and is a low-priority cleanup since kind environments don't have RDMA hardware anyway and the network-operator deployment there is largely a stub for recipe-completeness.Testing
Also manually verified
helm templateagainst the v26.1.1 chart with both AICR values files (values.yamlfor kind,values-aks.yamlfor AKS) — renders cleanly, no errors.Risk Assessment
make bom-docsproduces zero diff). The only behavioral change is: bundles built from kind/aks recipes now pull chart26.1.1instead of (25.1.0/26.1.0). Both are forward-compatible — the AKS values file uses only forward-compatible keys, and the kind values file has dead keys that are silently ignored on v26.1.1 the same way they were on prior versions.Rollout notes: Existing AICR-deployed clusters running kind or AKS recipes can helm-upgrade in place by regenerating the bundle and running
deploy.sh. The network-operator controller pod rotates once. No CRD migrations required (v26.1.x schema is the same forward from v26.0).Checklist
make testwith-race)make lint)git commit -S)