Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 4 additions & 24 deletions demos/cuj1-eks.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,30 +97,10 @@ spec:
nvidia.com/gpu: 1
limits:
nvidia.com/gpu: 1
# Inject AICR-standard GPU node scheduling. kubeflow-trainer v2.2.0 replaced
# podTemplateOverrides with the runtimePatches API (PR kubeflow/trainer#3309).
runtimePatches:
- manager: aicr.nvidia.com/demo
trainingRuntimeSpec:
template:
spec:
replicatedJobs:
- name: node
template:
spec:
template:
spec:
nodeSelector:
nodeGroup: gpu-worker
tolerations:
- key: dedicated
operator: Equal
value: worker-workload
effect: NoSchedule
- key: dedicated
operator: Equal
value: worker-workload
effect: NoExecute
# No podTemplateOverrides / runtimePatches needed — the torch-distributed
# ClusterTrainingRuntime carries the cluster-aware nodeSelector and
# tolerations baked in at bundle time from --accelerated-node-selector /
# --accelerated-node-toleration flags.
runtimeRef:
name: torch-distributed
apiGroup: trainer.kubeflow.org
Expand Down
30 changes: 4 additions & 26 deletions demos/cuj1-gke.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,32 +99,10 @@ spec:
nvidia.com/gpu: 1
limits:
nvidia.com/gpu: 1
# Inject GKE GPU node scheduling. Matches the snapshot/bundle/validate
# tolerations above (`dedicated=gpu-workload:NoSchedule` plus the GKE-managed
# `nvidia.com/gpu=present:NoSchedule` taint). kubeflow-trainer v2.2.0 replaced
# podTemplateOverrides with the runtimePatches API (PR kubeflow/trainer#3309).
runtimePatches:
- manager: aicr.nvidia.com/demo
trainingRuntimeSpec:
template:
spec:
replicatedJobs:
- name: node
template:
spec:
template:
spec:
nodeSelector:
nodeGroup: gpu-worker
tolerations:
- key: dedicated
operator: Equal
value: gpu-workload
effect: NoSchedule
- key: nvidia.com/gpu
operator: Equal
value: present
effect: NoSchedule
# No podTemplateOverrides / runtimePatches needed — the torch-distributed
# ClusterTrainingRuntime carries the cluster-aware nodeSelector and
# tolerations baked in at bundle time from --accelerated-node-selector /
# --accelerated-node-toleration flags.
runtimeRef:
name: torch-distributed
apiGroup: trainer.kubeflow.org
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,22 @@ spec:
spec:
template:
spec:
# nodeSelector and tolerations are injected by the AICR bundler
# from --accelerated-node-selector / --accelerated-node-toleration
# flags via the registry's nodeScheduling.accelerated paths
# (see recipes/registry.yaml). This lets users submit a bare
# TrainJob with no podTemplateOverrides / runtimePatches — the
# runtime carries the per-cluster scheduling vocabulary baked
# in at bundle time.
{{- $kft := index .Values "kubeflow-trainer" }}
{{- with $kft.acceleratedNodeSelector }}
nodeSelector:
{{- toYaml . | nindent 20 }}
{{- end }}
{{- with $kft.acceleratedTolerations }}
tolerations:
{{- toYaml . | nindent 20 }}
{{- end }}
containers:
- name: node
image: pytorch/pytorch:2.9.1-cuda12.8-cudnn9-runtime
10 changes: 10 additions & 0 deletions recipes/registry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -495,3 +495,13 @@ components:
tolerationPaths:
- manager.tolerations
- jobset.controller.tolerations
# accelerated paths target top-level keys; consumed by the
# torch-distributed ClusterTrainingRuntime template in
# components/kubeflow-trainer/manifests/. Lets users submit a bare
# TrainJob with no podTemplateOverrides / runtimePatches — the
# runtime carries the per-cluster scheduling baked in at bundle time.
accelerated:
nodeSelectorPaths:
- acceleratedNodeSelector
tolerationPaths:
- acceleratedTolerations
Loading