fix(bundler): v0.12 rc1 smoke-test follow-ups#677
Merged
Conversation
mchmarny
approved these changes
Apr 24, 2026
Contributor
Coverage Report ✅
Coverage BadgeMerging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This comment was marked as resolved.
This comment was marked as resolved.
f1c84f8 to
33792a1
Compare
33792a1 to
3315615
Compare
lockwobr
added a commit
that referenced
this pull request
Apr 28, 2026
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
lockwobr
added a commit
that referenced
this pull request
Apr 28, 2026
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
lockwobr
added a commit
that referenced
this pull request
Apr 28, 2026
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
lockwobr
added a commit
that referenced
this pull request
Apr 28, 2026
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
lockwobr
added a commit
that referenced
this pull request
Apr 28, 2026
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
lockwobr
added a commit
that referenced
this pull request
Apr 29, 2026
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix three minor issues found during 0.12.rc1 testing: wrong Skyhook taint
domain in docs/tests, missing
cluster-values.yamlin generated helmcommand snippets, and silent fallthrough when a
--dynamicpath is absentfrom component values.
Motivation / Context
Shaking out the 0.12.rc1 bundle output surfaced three small but user-visible
defects:
legacy
skyhook.io/runtime-requiredkey. The NVIDIA Skyhook operatoruses
skyhook.nvidia.com/runtime-required, so copy-pasting thedocumented
--workload-gatevalue produced a taint no Skyhook installwould ever match.
cluster-values.yaml. The Helmdeployer writes dynamic paths into a separate
cluster-values.yaml, butthe rendered README templates only referenced
values.yaml. Users whodeclared
--dynamicpaths and then ran the command from the READMEwould silently lose those install-time overrides.
--dynamic <component>:<path>names a path that isn't present in the component's values, both the
helmandargocd-helmdeployers fall back to writing an empty stringstub. That fallback is load-bearing (empty declarations are legitimate),
but producing it without any operator-visible signal made typos in
dynamic paths impossible to diagnose from the bundle alone.
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
Testing
# Commands run (prefer `make qualify` for non-trivial changes) make qualifyRisk Assessment
Rollout notes:
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info