Add Python-side guardrail for DeepEP IB limits#4719
Merged
Conversation
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
janEbert
added
the
Run MBridge tests
Also rename `seq_len` -> `num_tokens` for better understandability.
janEbert
force-pushed
the
fix-deepep-buffer-guard
branch
from
ef74c85 to
5c723f5
Compare
Contributor
|
PR passes internal MBridge tests |
svcnvidia-nemo-ci
added a commit
that referenced
this pull request
May 12, 2026
Merges 8 commits from main into dev. Dev already contains yesterday's sync (PR #4716) plus follow-up fixes, so this PR only carries main commits made after that sync. Notable changes: - 434368c build(deps): bump nvidia-modelopt to 0.43 (#4723) - e42e2fa ci: Major refactor of release-workflows (#4602) - 33d47e0 [ci] fix: treat cancelled run-main-script step as failure (#4727) - 5123f6a ci: revert bad uv.lock bump and label future bumps with Run functional tests (#4730) - ad58411 Add Python-side guardrail for DeepEP IB limits (#4719) - e93755e chore(beep boop): Bump (main) (2026-05-11) - a2ec5c1 Revert Add Python-side guardrail for HybridEP IB limit (#4718) - 5e31514 Create a Protocol for the MLP layer of TransformerLayer (#3435) Kept dev's pyproject.toml, uv.lock, docker/Dockerfile.ci.dev, and .github/CODEOWNERS (per nightly-sync skill). Ran black + isort on changed Python files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compared to the previous attempt in #4094, which didn't properly check (was overly conservative; this was only noticed in Megatron-Bridge tests) and had to be reverted (#4718), we add a lot more code to basically re-compute the DeepEP internal handling. This is necessary to handle all cases that DeepEP considers properly.
Another approach we could try to take is filtering the raised error from DeepEP, and giving the more helpful error message when we encounter the known one.
Ref #4094, #4718, fix #3999.