Add a knob to throttle the max allowed inflight offload in fine grained offloading#4692
Open
nanz-nv wants to merge 1 commit intoNVIDIA:mainfrom
Open
Add a knob to throttle the max allowed inflight offload in fine grained offloading#4692nanz-nv wants to merge 1 commit intoNVIDIA:mainfrom
nanz-nv wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Collaboration with @eee4017 @lhb8125
What
Introduces fine_grained_offloading_max_inflight_offloads on TransformerConfig: for each FGO group name, limits how many completed GPU→CPU offloads can stay unjoined on the default stream before older D2H events are waited on. The same cap applies to every name; each name has its own pending queue. None disables this behavior (unchanged from before for callers who don’t set it).
Why
Under full-iteration CUDA graph capture, the main stream may not otherwise synchronize with D2H work; joining when the per-name depth exceeds the cap gives a tunable backpressure knob and can help with reserved-memory / allocator behavior without a byte-based budget.
Also
Fix the FGO + local CUDA graph validation: compare cuda_graph_scope to [CudaGraphScope.full_iteration] after scope normalization, not the string "full_iteration".
Update the hybrid MoE golden config test snapshot for the new field.
dev PR: #4514
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.