Skip to content

Fix typos in training comments #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wanna-01 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Fix typos in training comments #4681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions megatron/training/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ def pretrain(
ft_integration.setup()
timestamp_after_in_job_setup = time.time()

# Initalize and get arguments, timers, and Tensorboard writer.
# Initialize and get arguments, timers, and Tensorboard writer.
initialize_megatron(
get_embedding_ranks=get_embedding_ranks,
get_position_embedding_ranks=get_position_embedding_ranks,
Expand Down Expand Up @@ -1960,7 +1960,7 @@ def _save_state_dict(attr_name, label):
if save_params_in_this_iteration:
_save_state_dict(attr_name="data", label="params")

# when freezing sub-models we may have a mixture of successful and unsucessful ranks,
# when freezing sub-models we may have a mixture of successful and unsuccessful ranks,
# so we must gather across mp ranks
update_successful = logical_and_across_model_parallel_group(update_successful)
# grad_norm and num_zeros_in_grad will be None on ranks without trainable params,
Expand Down
Loading