[MXFP8/FP4-param-gather] Post processing after forced param AG in eval#4562
Open
WanZzzzzz wants to merge 7 commits intoNVIDIA:mainfrom
Open
[MXFP8/FP4-param-gather] Post processing after forced param AG in eval#4562WanZzzzzz wants to merge 7 commits intoNVIDIA:mainfrom
WanZzzzzz wants to merge 7 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: qiyuw <qiyuw@nvidia.com>
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
5 tasks
Signed-off-by: qiyuw <qiyuw@nvidia.com>
Signed-off-by: qiyuw <qiyuw@nvidia.com>
Signed-off-by: qiyuw <qiyuw@nvidia.com>
Signed-off-by: qiyuw <qiyuw@nvidia.com>
Signed-off-by: qiyuw <qiyuw@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The same PR to dev has been merged: #4563
Fixes FP8/MXFP8/FP4 parameter-gather convergence when eval runs between training steps.
When eval disables forward pre-hooks, start_param_sync(force_sync=True) can complete parameter all-gather synchronously. In that path there is no async gather handle for the next train forward hook to wait on (line), so the usual post-all-gather processing was skipped in next train step. In eval, the post processing is also skipped if the job enables overlap_param_gather (line). With FP8 (blockwise scaling) or FP4 param gather, this can leave columnwise weight storage stale while rowwise storage has been refreshed, causing the next train backward to use staled weights. With MXFP8 param+reuse_grad_buff_for_mxfp8_param_ag, the AG'ed weights will not be copied(quantized) from param buffer to model weights, which is not correct.
In this PR we add post processing in bucket group's start_param_sync for synchronous gather, hence making sure the above cases are correctly handled.
Validated the fix on DSv3 proxy model pretraining for FP4 param gather:

Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.