Skip to content

test: validate mismatch between PodGroup's root minMember and leaf subgroups minMember sum#943

Open
gshaibi wants to merge 2 commits intomainfrom
shaibi/validate-top-bottom-min-member-mismatch
Open

test: validate mismatch between PodGroup's root minMember and leaf subgroups minMember sum#943
gshaibi wants to merge 2 commits intomainfrom
shaibi/validate-top-bottom-min-member-mismatch

Conversation

@gshaibi
Copy link
Collaborator

@gshaibi gshaibi commented Feb 1, 2026

No description provided.

@gshaibi gshaibi changed the title . test: validate mismatch between PodGroup's root minMember and leaf subgroups minMember sum Feb 1, 2026
@github-actions
Copy link

github-actions bot commented Feb 1, 2026 •
edited
Loading

📊 Performance Benchmark Results

Comparing PR (shaibi/validate-top-bottom-min-member-mismatch) vs main branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
                                    │ main-bench.txt │            pr-bench.txt            │
                                    │     sec/op     │    sec/op     vs base              │
AllocateAction_SmallCluster-4           108.1m ±  1%   108.6m ±  9%       ~ (p=0.180 n=6)
AllocateAction_MediumCluster-4          135.3m ±  3%   135.8m ±  2%       ~ (p=0.589 n=6)
AllocateAction_LargeCluster-4           218.7m ± 24%   227.7m ± 13%       ~ (p=0.937 n=6)
ReclaimAction_SmallCluster-4            102.8m ±  0%   102.9m ±  0%       ~ (p=0.240 n=6)
ReclaimAction_MediumCluster-4           105.6m ±  0%   105.7m ±  0%       ~ (p=0.818 n=6)
PreemptAction_SmallCluster-4            103.6m ±  0%   103.6m ±  0%       ~ (p=0.818 n=6)
PreemptAction_MediumCluster-4           113.6m ±  0%   113.4m ±  0%       ~ (p=0.310 n=6)
ConsolidationAction_SmallCluster-4      114.1m ±  0%   114.0m ±  0%       ~ (p=0.132 n=6)
ConsolidationAction_MediumCluster-4     205.6m ±  1%   203.9m ±  1%       ~ (p=0.093 n=6)
FullSchedulingCycle_SmallCluster-4      105.5m ±  0%   105.4m ±  0%       ~ (p=0.394 n=6)
FullSchedulingCycle_MediumCluster-4     119.7m ±  0%   119.6m ±  0%       ~ (p=0.485 n=6)
FullSchedulingCycle_LargeCluster-4      158.7m ±  1%   159.0m ±  1%       ~ (p=0.310 n=6)
ManyQueues_MediumCluster-4              140.2m ±  1%   141.0m ±  1%       ~ (p=0.180 n=6)
GangScheduling_MediumCluster-4          158.5m ±  1%   159.9m ±  1%  +0.86% (p=0.041 n=6)
geomean                                 130.8m         131.3m        +0.39%

                                    │ main-bench.txt │            pr-bench.txt            │
                                    │      B/op      │     B/op      vs base              │
AllocateAction_SmallCluster-4           2.152Mi ± 0%   2.152Mi ± 1%       ~ (p=0.818 n=6)
AllocateAction_MediumCluster-4          11.84Mi ± 0%   11.84Mi ± 0%       ~ (p=0.699 n=6)
AllocateAction_LargeCluster-4           41.54Mi ± 0%   41.54Mi ± 0%       ~ (p=0.699 n=6)
ReclaimAction_SmallCluster-4            887.5Ki ± 1%   892.7Ki ± 1%       ~ (p=0.240 n=6)
ReclaimAction_MediumCluster-4           2.830Mi ± 0%   2.828Mi ± 0%       ~ (p=0.818 n=6)
PreemptAction_SmallCluster-4            1.006Mi ± 0%   1.007Mi ± 1%       ~ (p=0.589 n=6)
PreemptAction_MediumCluster-4           4.020Mi ± 0%   4.020Mi ± 0%       ~ (p=1.000 n=6)
ConsolidationAction_SmallCluster-4      5.602Mi ± 0%   5.604Mi ± 0%       ~ (p=0.310 n=6)
ConsolidationAction_MediumCluster-4     46.88Mi ± 0%   46.88Mi ± 0%       ~ (p=0.699 n=6)
FullSchedulingCycle_SmallCluster-4      1.372Mi ± 0%   1.372Mi ± 0%       ~ (p=0.937 n=6)
FullSchedulingCycle_MediumCluster-4     6.836Mi ± 0%   6.836Mi ± 0%       ~ (p=0.937 n=6)
FullSchedulingCycle_LargeCluster-4      22.83Mi ± 0%   22.83Mi ± 0%       ~ (p=0.818 n=6)
ManyQueues_MediumCluster-4              16.30Mi ± 0%   16.30Mi ± 0%       ~ (p=0.937 n=6)
GangScheduling_MediumCluster-4          17.17Mi ± 0%   17.17Mi ± 0%       ~ (p=0.937 n=6)
geomean                                 6.329Mi        6.332Mi       +0.04%

                                    │ main-bench.txt │           pr-bench.txt            │
                                    │   allocs/op    │  allocs/op   vs base              │
AllocateAction_SmallCluster-4            36.21k ± 0%   36.21k ± 0%       ~ (p=1.000 n=6)
AllocateAction_MediumCluster-4           325.2k ± 0%   325.2k ± 0%       ~ (p=0.723 n=6)
AllocateAction_LargeCluster-4            1.394M ± 0%   1.394M ± 0%       ~ (p=0.177 n=6)
ReclaimAction_SmallCluster-4             8.395k ± 0%   8.396k ± 0%       ~ (p=0.667 n=6)
ReclaimAction_MediumCluster-4            26.54k ± 0%   26.54k ± 0%       ~ (p=0.716 n=6)
PreemptAction_SmallCluster-4             11.19k ± 0%   11.19k ± 0%       ~ (p=0.662 n=6)
PreemptAction_MediumCluster-4            38.77k ± 0%   38.77k ± 0%       ~ (p=0.859 n=6)
ConsolidationAction_SmallCluster-4       73.55k ± 0%   73.57k ± 0%       ~ (p=0.394 n=6)
ConsolidationAction_MediumCluster-4      685.8k ± 0%   685.9k ± 0%       ~ (p=0.937 n=6)
FullSchedulingCycle_SmallCluster-4       21.36k ± 0%   21.36k ± 0%       ~ (p=1.000 n=6)
FullSchedulingCycle_MediumCluster-4      174.7k ± 0%   174.7k ± 0%       ~ (p=0.461 n=6)
FullSchedulingCycle_LargeCluster-4       727.3k ± 0%   727.3k ± 0%       ~ (p=0.615 n=6)
ManyQueues_MediumCluster-4               363.3k ± 0%   363.3k ± 0%       ~ (p=1.000 n=6)
GangScheduling_MediumCluster-4           597.0k ± 0%   597.0k ± 0%       ~ (p=0.974 n=6)
geomean                                  111.7k        111.7k       +0.00%

Legend

  • 📉 Negative delta = Performance improvement (faster)
  • 📈 Positive delta = Performance regression (slower)
  • p-value < 0.05 indicates statistically significant change
Raw benchmark data

PR branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	       9	 118310879 ns/op	 2283421 B/op	   36217 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108787603 ns/op	 2257637 B/op	   36207 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108364562 ns/op	 2255493 B/op	   36202 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108825060 ns/op	 2258904 B/op	   36210 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108424351 ns/op	 2254893 B/op	   36202 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108023984 ns/op	 2255689 B/op	   36204 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136014707 ns/op	12439206 B/op	  325203 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134657053 ns/op	12417449 B/op	  325192 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 137856049 ns/op	12414989 B/op	  325182 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 138103847 ns/op	12416289 B/op	  325191 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135178950 ns/op	12416872 B/op	  325190 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135557242 ns/op	12420840 B/op	  325194 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 207193897 ns/op	43557684 B/op	 1394292 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 237456636 ns/op	43557174 B/op	 1394296 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       4	 257807073 ns/op	43563912 B/op	 1394281 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 207938745 ns/op	43556464 B/op	 1394287 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 231625557 ns/op	43564515 B/op	 1394290 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 223805948 ns/op	43555120 B/op	 1394277 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102834524 ns/op	  905082 B/op	    8365 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102875848 ns/op	  910855 B/op	    8390 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102870114 ns/op	  914320 B/op	    8398 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102876663 ns/op	  914346 B/op	    8398 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102804676 ns/op	  913840 B/op	    8396 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102871207 ns/op	  915151 B/op	    8396 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105735228 ns/op	 2965487 B/op	   26538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105423897 ns/op	 2965583 B/op	   26538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105655295 ns/op	 2965324 B/op	   26537 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105628507 ns/op	 2969477 B/op	   26539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105702143 ns/op	 2965562 B/op	   26538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105884198 ns/op	 2969383 B/op	   26539 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103742833 ns/op	 1055896 B/op	   11188 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103673108 ns/op	 1055893 B/op	   11188 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103799386 ns/op	 1051994 B/op	   11187 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103593300 ns/op	 1048023 B/op	   11185 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103608461 ns/op	 1058572 B/op	   11187 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103552553 ns/op	 1056084 B/op	   11189 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113597546 ns/op	 4210955 B/op	   38770 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113450472 ns/op	 4215110 B/op	   38770 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113445595 ns/op	 4206733 B/op	   38768 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113262232 ns/op	 4215355 B/op	   38772 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113667518 ns/op	 4215266 B/op	   38771 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113151558 ns/op	 4215360 B/op	   38771 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113996043 ns/op	 5873990 B/op	   73541 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 114022232 ns/op	 5877270 B/op	   73584 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 114121536 ns/op	 5876900 B/op	   73577 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113977199 ns/op	 5897186 B/op	   73594 allocs/op

Main branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	      10	 108138883 ns/op	 2256520 B/op	   36207 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107748798 ns/op	 2257245 B/op	   36205 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 109041906 ns/op	 2263748 B/op	   36207 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108069823 ns/op	 2256872 B/op	   36203 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108132502 ns/op	 2256739 B/op	   36205 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108156592 ns/op	 2256681 B/op	   36206 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135554062 ns/op	12419105 B/op	  325193 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 138755692 ns/op	12416923 B/op	  325190 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 137671005 ns/op	12426849 B/op	  325192 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134556826 ns/op	12417714 B/op	  325198 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134758593 ns/op	12415676 B/op	  325181 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135018661 ns/op	12419810 B/op	  325190 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 217547347 ns/op	43557188 B/op	 1394290 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 218375778 ns/op	43555520 B/op	 1394282 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 271751911 ns/op	43557004 B/op	 1394300 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 226067852 ns/op	43558739 B/op	 1394310 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 218586604 ns/op	43557017 B/op	 1394290 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 218738454 ns/op	43557548 B/op	 1394306 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102882845 ns/op	  901516 B/op	    8367 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102859639 ns/op	  906404 B/op	    8380 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102866808 ns/op	  914175 B/op	    8398 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102772862 ns/op	  906348 B/op	    8394 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102789412 ns/op	  911232 B/op	    8395 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102786580 ns/op	  914215 B/op	    8397 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 106002189 ns/op	 2965504 B/op	   26538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105340998 ns/op	 2969613 B/op	   26539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105489163 ns/op	 2969541 B/op	   26540 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105824548 ns/op	 2961556 B/op	   26536 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105453868 ns/op	 2969436 B/op	   26539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105684874 ns/op	 2965452 B/op	   26538 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103621607 ns/op	 1055840 B/op	   11189 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103585893 ns/op	 1055940 B/op	   11188 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103759223 ns/op	 1051735 B/op	   11185 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103522013 ns/op	 1054602 B/op	   11185 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103742711 ns/op	 1055943 B/op	   11188 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103670524 ns/op	 1051440 B/op	   11184 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113531205 ns/op	 4215135 B/op	   38771 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113200709 ns/op	 4215245 B/op	   38771 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113665054 ns/op	 4215410 B/op	   38772 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113558695 ns/op	 4215288 B/op	   38771 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113771116 ns/op	 4210907 B/op	   38770 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113625821 ns/op	 4210697 B/op	   38768 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 114010192 ns/op	 5870676 B/op	   73517 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 114330236 ns/op	 5874857 B/op	   73546 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 114155896 ns/op	 5887455 B/op	   73591 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 114110669 ns/op	 5878185 B/op	   73592 allocs/op

@github-actions
Copy link

github-actions bot commented Feb 1, 2026

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info 66.67% (+6.54%) 👍
Coverage by file

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/job_info_test.go

@gshaibi gshaibi enabled auto-merge February 1, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gshaibi