Fix-207 Add configurable scheduler actions field#889
Open
AdheipSingh wants to merge 1 commit intoNVIDIA:mainfrom
Open
Fix-207 Add configurable scheduler actions field#889AdheipSingh wants to merge 1 commit intoNVIDIA:mainfrom
AdheipSingh wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Collaborator
|
Hi @AdheipSingh We want to implement a more whole solution following this design: #833 |
enoodle
reviewed
Jan 19, 2026
Comment on lines
+134
to
144
| if len(shard.Spec.Actions) > 0 { | ||
| // Use custom actions from shard spec | ||
| actions = shard.Spec.Actions | ||
| } else { | ||
| // Default actions | ||
| actions = []string{string(framework.Allocate)} | ||
| if placementArguments[gpuResource] != spreadStrategy && placementArguments[cpuResource] != spreadStrategy { | ||
| actions = append(actions, string(framework.Consolidation)) | ||
| } | ||
| actions = append(actions, string(framework.Reclaim), string(framework.Preempt), string(framework.StaleGangEviction)) | ||
| } |
Collaborator
There was a problem hiding this comment.
Our convention is to set the defaults on the type (SetDefaultsWhereNeeded) and then we don't need them here.
Also please try to avoid obvious comments - they waste tokens.
Author
|
Hi @enoodle Thanks for the update and pointing me to the PR i was not aware. I'll read over and then get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added actions field to SchedulingShard CRD allowing users to configure
which scheduler actions run.
Changes:
actions if provided, otherwise use defaults
option
SchedulingShard
Usage:
scheduler:
actions: ["allocate", "reclaim", "preempt"] # excludes consolidation and
stalegangeviction
Default behavior unchanged - if actions is empty, uses: allocate,
consolidation, reclaim, preempt, stalegangeviction
Related Issues
Fixes #207
Checklist
Breaking Changes
Additional Notes
cc @enoodle