Remove unused forward declarations

[wujingyue]

No description provided.

[wujingyue]

!test

[greptile-apps]

Greptile Overview

Greptile Summary

This PR removes two unused forward declarations from csrc/ir/internal_nodes.h: class ViewTransform and struct AnalyzeViewResult. These types are defined in csrc/transform_view.h but were never actually used anywhere in internal_nodes.h or its implementation file.

• Removed forward declaration for class ViewTransform
• Removed forward declaration for struct AnalyzeViewResult
• Kept class IrCloner forward declaration (still used in the file)

Confidence Score: 5/5

• This PR is completely safe to merge - it only removes unused forward declarations
• The removed forward declarations (ViewTransform and AnalyzeViewResult) were verified to be completely unused in the file through grep searches. The git history confirms they were never used since their introduction. The remaining forward declaration (IrCloner) is still properly used within the file. This is a pure cleanup change with zero functional impact.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
csrc/ir/internal_nodes.h	5/5	Removed two unused forward declarations (ViewTransform and AnalyzeViewResult) that were never referenced in the file

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant File as internal_nodes.h
    participant Compiler as C++ Compiler
    
    Note over Dev,Compiler: Before PR
    Dev->>File: ViewTransform forward declaration exists
    Dev->>File: AnalyzeViewResult forward declaration exists
    Note over File: Forward declarations unused<br/>but present in file
    File->>Compiler: Compiles successfully
    
    Note over Dev,Compiler: After PR
    Dev->>File: Remove ViewTransform forward declaration
    Dev->>File: Remove AnalyzeViewResult forward declaration
    Note over File: Only IrCloner forward<br/>declaration remains (used)
    File->>Compiler: Compiles successfully
    Note over Compiler: No compilation errors<br/>Cleaner header file

Loading

[github-actions]

Description

• Remove unused forward declarations from internal_nodes.h

• Deleted class ViewTransform; forward declaration

• Deleted struct AnalyzeViewResult; forward declaration

• Kept class IrCloner; as it's still referenced

Changes walkthrough

	Relevant files
Enhancement	internal_nodes.h Remove unused forward declarations from internal_nodes.h  csrc/ir/internal_nodes.h Removed unused forward declaration for ViewTransform class Removed unused forward declaration for AnalyzeViewResult struct Kept IrCloner forward declaration as it's still needed This cleanup reduces unnecessary forward declarations in the IR header +0/-2

PR Reviewer Guide

Here are some key observations to aid the review process:

🧪 PR contains tests

⚡ Recommended focus areas for review

Verify unused declarations Ensure that the removed forward declarations (ViewTransform and AnalyzeViewResult) are indeed unused throughout the entire codebase. The reviewer should verify that removing these declarations doesn't cause any compilation issues or break any existing code that might depend on them.