-
Notifications
You must be signed in to change notification settings - Fork 74
Migrate from pybind11 to nanobind #5780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review updated until commit f264148 Description
|
| Relevant files |
|---|
PR Reviewer Guide
Here are some key observations to aid the review process:
| 🧪 No relevant tests |
| ⚡ Recommended focus areas for review |
API Migration Completeness
|
Test failures
-
(High, 46)
System-wide NCCL NVLink-SHARP (NVLS) binding failure in multidevice nvFuser/distributed tests on dlcluster_viking_ciTest Name H100 (dist.) Source tests.python.multidevice.test_communication.test_allgather ❌ tests.python.multidevice.test_communication.test_allgather_expanded_broadcast ❌ tests.python.multidevice.test_communication.test_allreduce ❌ tests.python.multidevice.test_communication.test_reduce_scatter ❌ tests.python.multidevice.test_communication.test_reduce_scatter_noncontiguous ❌ tests.python.multidevice.test_dtensor.test_column_parallel_linear ❌ tests.python.multidevice.test_dtensor.test_plus_one ❌ tests.python.multidevice.test_dtensor.test_row_parallel_linear ❌ tests.python.multidevice.test_expert_parallel.test_dispatch_and_combine ❌ tests.python.multidevice.test_matmul.test_column_parallel_grouped_mm ❌ ... with 36 more test failures omitted. Check internal logs. -
(Medium, 18)
nvFuser define_tensor() argument mismatch in OpInfo legacy error tests (multiple dtypes)Test Name A100 GB200 H100 Source tests.python.opinfo.test_legacy_ops.test_errors_define_tensor_complex128 ❌ ❌ ❌ tests.python.opinfo.test_legacy_ops.test_errors_define_tensor_complex64 ❌ ❌ ❌ tests.python.opinfo.test_legacy_ops.test_errors_define_tensor_float32 ❌ ❌ ❌ tests.python.opinfo.test_legacy_ops.test_errors_define_tensor_float64 ❌ ❌ ❌ tests.python.opinfo.test_legacy_ops.test_errors_define_tensor_int32 ❌ ❌ ❌ tests.python.opinfo.test_legacy_ops.test_errors_define_tensor_int64 ❌ ❌ ❌ -
(Medium, 1)
NCCL invalid usage error in tests/python/multidevice overlap testTest Name H100 (dist.) Source tests.python.multidevice.test_overlap.test_overlap_allgather_matmul_shard_outermost[backend_type=CommunicatorBackend.cuda] ❌
1373f72 to
d5b6860
Compare
d5b6860 to
86311db
Compare
87e8c35 to
02c761e
Compare
|
!test |
Library Size -- Nanobind is 52.6% smaller than PyBind11