Skip to content

Support Wan nemo-ci long convergence tests#3742

Open
huvunvidia wants to merge 1 commit intomainfrom
huvu/wan_long_convergence_cicd
Open

Support Wan nemo-ci long convergence tests#3742
huvunvidia wants to merge 1 commit intomainfrom
huvu/wan_long_convergence_cicd

Conversation

@huvunvidia
Copy link
Copy Markdown
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@huvunvidia huvunvidia requested review from a team, erhoo82 and malay-nagda as code owners May 7, 2026 19:40
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 7, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 7, 2026

Light code review - LGTM with minor notes. The change is correct - both WanDatasetConfig.path and FluxDatasetConfig.path exist as dataclass fields. Observations: (1) PR description template not filled in. (2) Consider adding a unit test for the new diffusion_dataset_path CLI arg. (3) CI skips functional tests for perf-scripts-only changes. Suggested test cases: No perf tests impacted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants