[ci, build] chore: revert revert of PR #3702 (restore hybridep docker move)#3734
Merged
Conversation
Contributor
Author
|
/ok to test 49b5460 |
Contributor
ko3n1g
force-pushed
the
ko3n1g/ci/reapply-revert-3702
branch
from
49b5460 to
a8ad643
Compare
Contributor
Author
|
/ok to test a8ad643 |
… move) Reverts 4f21a31 (#3729), restoring the hybridep docker install move from Dockerfile.fw_base into Dockerfile.ci that PR #3702 originally introduced. Done to retest whether the VLM perf regression suspected to be caused by the move is still reproducible on current main. Original revert message: This reverts commit 4f21a31. Signed-off-by: oliver könig <okoenig@nvidia.com>
ko3n1g
force-pushed
the
ko3n1g/ci/reapply-revert-3702
branch
from
a8ad643 to
49c5e5e
Compare
ko3n1g
changed the title
Contributor
Author
|
/ok to test 49c5e5e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude summary
Reverts
4f21a31d(#3729), which had reverted PR #3702 to investigate a VLM perf regression. This restores PR #3702's change: the hybridep / DeepEP install (withHYBRID_EP_MULTINODEandLD_LIBRARY_PATHenv vars) is moved fromdocker/Dockerfile.fw_baseback intodocker/Dockerfile.ci.Submitted to retest CI on current
mainto see whether the VLM converter regression is still reproducible.