Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/megatron/bridge/training/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,14 @@ def train(
if energy_monitor is not None:
energy_monitor.pause()
timers("interval-time").stop()
if config.optimizer.reuse_grad_buf_for_mxfp8_param_ag and config.ddp.overlap_param_gather:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# disable_forward_pre_hook(param_sync=True) below force-syncs params for eval.
# Copy the main params to param buffer before the forced AllGather.
for model_chunk in model:
model_chunk.zero_grad_buffer()
for optim_instance in optimizer.chained_optimizers:
if isinstance(optim_instance, DistributedOptimizer):
optim_instance._copy_main_params_to_param_buffer()
if should_toggle_forward_pre_hook:
disable_forward_pre_hook(model)
pre_hook_enabled = False
Expand Down
Loading