Skip to content

ci: Major refactor of release-workflows#3725

Open
ko3n1g wants to merge 11 commits intomainfrom
ko3n1g/ci/changelog-hybrid
Open

ci: Major refactor of release-workflows#3725
ko3n1g wants to merge 11 commits intomainfrom
ko3n1g/ci/changelog-hybrid

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented May 6, 2026 •
edited
Loading

Why

See the design discussion in NVIDIA-NeMo/FW-CI-templates#466.

What

  • Delete .github/workflows/build-test-publish-wheel.yml.
  • Rewrite .github/workflows/release.yaml as the single caller for both push and workflow_dispatch.

Test plan

Rollout

  1. Land FW-CI-templates#466.
  2. Cut FW-CI-templates v1.0.0.
  3. Bump the SHA pin in this PR → tag.

@ko3n1g ko3n1g requested a review from a team as a code owner May 6, 2026 22:25
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/changelog-hybrid branch from 1c3b7a5 to b375633 Compare May 6, 2026 22:27
@ko3n1g @claude
ci(changelog): add cp-title transformer
bb7862f 
Strips `cp: \`...\` into r0.4.0` wrapper from cherry-pick PR
titles in the auto-generated changelog. Pairs with FW-CI-templates
default mode flip to HYBRID (so cp commits also render).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/changelog-hybrid branch from b375633 to bb7862f Compare May 6, 2026 22:27
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 6, 2026

Light Code Review

Clean consolidation — folds build-test-publish-wheel.yml into release.yaml with validate-only for push triggers, bumps FW-CI for HYBRID changelog, and adds a cp-title transformer. Two minor items:

1. Missing trailing newline in changelog-config.json — The diff removes the trailing newline from the JSON file. While not functionally broken, POSIX tools and some linters expect a trailing newline. Worth restoring.

2. FW-CI pinned to raw SHA instead of a tag — The old pin was v0.93.0. A raw SHA is harder to audit and will not show up in Dependabot/Renovate scans. Consider tagging the FW-CI commit and switching back to a tag reference once the upstream cut is available, or adding a comment with the equivalent version.

No issues found with: the cp-title transformer regex (correctly strips the cherry-pick wrapper); the concurrency group and cancel-in-progress logic (only cancels on push); the release-summary job (improved conclusion filtering); the validate-only / dry-run split; and the removal of PAT, SSH_KEY, SSH_PWD secrets (aligned with new FW-CI template).

Suggested test cases: No perf tests impacted.

@yaoyu-33 yaoyu-33 added area:misc Cross-cutting utilities, logging, helpers, and other changes needs-review PR is ready for code review and waiting on a reviewer labels May 7, 2026
yaoyu-33
yaoyu-33 previously approved these changes May 7, 2026
View reviewed changes
@yaoyu-33 yaoyu-33 added the ready-to-merge PR is approved, current, and only waiting for CI to pass before merge label May 7, 2026
@ko3n1g @claude
refactor(release): bump FW-CI pin to b57ebf9 ([skip ci] on bump commit)
4bd7be9 
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 7, 2026

/ok to test 4bd7be9

@ko3n1g @claude
refactor(release): bump FW-CI pin to cb5e93b (notify env public for d…
150ad00 
…ry-run)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 7, 2026

/ok to test 150ad00

@ko3n1g
ci: bump FW-CI pin to 64293f6 (slack render fix)
5eeb09a 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented May 7, 2026

/ok to test 5eeb09a

meatybobby
meatybobby previously approved these changes May 7, 2026
View reviewed changes
@ko3n1g
ci: pin FW-CI templates to v1.0.0
c32a038 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g changed the title ci(changelog): default to HYBRID + add cp-title transformer ci: Major refactor of release-workflows May 7, 2026
@ko3n1g
ci: pragma allowlist secret on 'secrets: inherit' lines
c4e3a2c 
Signed-off-by: oliver könig <okoenig@nvidia.com>
chtruong814
chtruong814 previously approved these changes May 7, 2026
View reviewed changes
ko3n1g added 2 commits May 8, 2026 08:20
@ko3n1g
ci: simplify release-summary if-block (always() was dead code)
dd236ba 
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
ci: simplify release if-block (replace explicit success/skipped with …
bdfa065 
…!failure)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chtruong814 chtruong814 chtruong814 approved these changes

@meatybobby meatybobby meatybobby left review comments

@yaoyu-33 yaoyu-33 yaoyu-33 left review comments

Assignees

No one assigned

Labels

area:misc Cross-cutting utilities, logging, helpers, and other changes needs-review PR is ready for code review and waiting on a reviewer ready-to-merge PR is approved, current, and only waiting for CI to pass before merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ko3n1g @meatybobby @yaoyu-33 @chtruong814