Open
Conversation
yomcube
force-pushed
the
d_logo_screen
branch
from
4eb62cc to
032c4fc
Compare
Report for SMNP01 (a6f256f - 3091e9a)📈 Matched code: 3.44% (+0.02%, +1172 bytes) ✅ 14 new matches
🥀 2 broken matches
📈 4 improvements in unmatched items
📉 2 regressions in unmatched items
|
RootCubed
force-pushed
the
d_logo_screen
branch
from
dfb2051 to
3091e9a
Compare
CLF78
requested changes
Apr 11, 2026
|
|
||
| /// @brief Displays the Wii Strap safety warning screen. | ||
| /// @details Loops between the two images that show the safety warning and how to put on the strap. | ||
| /// Note that pressing a button to advance from the screen is handled by dScBoot_c. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Note that pressing a button to advance from the screen is handled by dScBoot_c. | |
| /// @note The button press to advance from this screen is handled by dScBoot_c. |
Comment on lines
+10
to
+12
| dWiiStrapScreen_c::dWiiStrapScreen_c() { | ||
| mHasLoadedLayout = false; | ||
| } |
Comment on lines
+58
to
+75
| char filename[100]; | ||
| memset(filename, 0, 100); | ||
| strncat(filename, "wiiStrap_", 99); | ||
| switch (dGameCom::GetLanguageHBM()) { | ||
| default: | ||
| strncat(filename, "EngEU_00", 99); break; | ||
| case SC_LANG_FR: | ||
| strncat(filename, "FraEU_00", 99); break; | ||
| case SC_LANG_DE: | ||
| strncat(filename, "GerEU_00", 99); break; | ||
| case SC_LANG_IT: | ||
| strncat(filename, "ItaEU_00", 99); break; | ||
| case SC_LANG_SP: | ||
| strncat(filename, "SpaEU_00", 99); break; | ||
| case SC_LANG_NL: | ||
| strncat(filename, "NedEU_00", 99); break; | ||
| } | ||
| strncat(filename, ".brlyt", 99); |
Contributor
There was a problem hiding this comment.
Please use a constant to make the string lengths derived from the array size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: match data, match stack offsets in
createLayout(), cleanup, documentation