Update make templates to guess HDF5 directories#22
Open
underwoo wants to merge 1 commit intoNOAA-GFDL:mainfrom
Open
Update make templates to guess HDF5 directories#22underwoo wants to merge 1 commit intoNOAA-GFDL:mainfrom
underwoo wants to merge 1 commit intoNOAA-GFDL:mainfrom
Conversation
Added new configuration variables HDF5_LDFLAGS and HDF5_FLAGS to allow user to set location of HDF5 directories. Also added bits to have make guess location using the `h5fc -show` command.
thomas-robinson
requested changes
Dec 2, 2019
Member
thomas-robinson
left a comment
thomas-robinson
left a comment
There was a problem hiding this comment.
I also noticed this HDF5 issue and was working on something to fix it. This is much more elegant than my hack fix.
I'm curious about the MPI changes. We can either update the commit message or include it the merge commit message.
| ifndef MPI_FLAGS | ||
| FPPFLAGS += $(shell pkg-config --cflags-only-I mpich2-c) | ||
| else | ||
| ifdef MPI_FLAGS |
Member
There was a problem hiding this comment.
@underwoo did you intend to also change the MPI flags in the make templates? It's not mentioned in the commit message.
Member
Author
|
I did. The problem with the MPI_FLAGS is that it was specific for mpich2.
Any other MPI library could not be used. The way MPI should be handled is
via the mpi compiler wrappers: `mpicc`, `mpif90`, etc.
…--
Seth Underwood
S/W Development Process Lead
Modeling Systems Group
GFDL/NOAA/DOC
201 Forrestal Road
Princeton, NJ 08540-6649
(609) 452-5847 Office
(304) 376-9002 Cell
(609) 987-5063 Fax
Seth.Underwood@noaa.gov
On Mon, Dec 2, 2019 at 8:42 AM Tom Robinson ***@***.***> wrote:
***@***.**** requested changes on this pull request.
I also noticed this HDF5 issue and was working on something to fix it.
This is much more elegant than my hack fix.
I'm curious about the MPI changes. We can either update the commit message
or include it the merge commit message.
------------------------------
In exec/templates/gnu.mk
<#22 (comment)>:
> @@ -96,9 +101,7 @@ else
FPPFLAGS += $(NETCDF_FLAGS)
endif
# Fortran Compiler flags for the MPICH MPI library
-ifndef MPI_FLAGS
-FPPFLAGS += $(shell pkg-config --cflags-only-I mpich2-c)
-else
+ifdef MPI_FLAGS
@underwoo <https://github.com/underwoo> did you intend to also change the
MPI flags in the make templates? It's not mentioned in the commit message.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22?email_source=notifications&email_token=AADJUS4UACQBIXAJGV5JXJLQWUGEZA5CNFSM4JSLJ2XKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNRM5JQ#pullrequestreview-325242534>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJUS76YD7QQXOLXTSC3Z3QWUGEZANCNFSM4JSLJ2XA>
.
|
Member
Author
|
@thomas-robinson this is still open, should it be or can it be closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new configuration variables HDF5_LDFLAGS and HDF5_FLAGS to allow user to set location of HDF5 directories. Also added bits to have make guess location using the
h5fc -showcommand.Fixes #21