Update Opakapaka case study and add back to github.io page#101
Open
iantaylor-NOAA wants to merge 12 commits into
Open
Update Opakapaka case study and add back to github.io page#101iantaylor-NOAA wants to merge 12 commits into
iantaylor-NOAA wants to merge 12 commits into
Conversation
- no longer requires case-studies code to create age-to-length-conversion or wtatatage - estimation not currently working
- also add to _quarto.yml to get it to render
There was a problem hiding this comment.
Pull request overview
Updates the PIFSC ‘Ōpakapaka case study to use the newer r4ss::ss3_data_to_fims() pathway (reducing custom SS3-to-FIMS data wrangling), and re-enables the case study in the rendered GitHub Pages site.
Changes:
- Refactors the ‘Ōpakapaka case study data-prep to use
r4ss::ss3_data_to_fims()and updates plots/parameter setup accordingly. - Adds the case study back into the Quarto render list + sidebar navigation (with Hawaiian diacritics in the title).
- Switches CI/devcontainer dependency install from an
r4ssfeature branch togithub::r4ss/r4ss.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
content/PIFSC-opakapaka.qmd |
Reworks SS3→FIMS data conversion and updates model setup/plots; re-titles the case study. |
_quarto.yml |
Adds the ‘Ōpakapaka case study back to rendering and sidebar nav. |
.github/workflows/render.yml |
Updates CI dependency install to pull r4ss from default branch. |
.github/workflows/render-and-publish.yml |
Updates publish workflow dependency install to pull r4ss from default branch. |
.devcontainer/devcontainer.json |
Updates devcontainer package list to pull r4ss from default branch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
405
to
407
| dplyr::rows_update( | ||
| tibble::tibble( | ||
| module_name = "Recruitment", |
| opaka_ctl$sd_ratio <- NULL | ||
| opaka_ctl$submorphdist <- NULL | ||
|
|
||
| # remove intial F estimation |
| group_by(datestart) |> | ||
| reframe(prop = value/sum(value)) | ||
| prop.dat <- opaka_dat_fims |> | ||
| filter(type == "length" & name == "BFISH") |> |
Contributor
Author
|
@MOshima-PIFSC, if you're back and have any time to spare, you could look at these changes. Feel free to make additional changes, or raise any issues you find. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the feature?
I updated the opakapaka case study to use
r4ss::ss3_data_to_fims()which eliminates the need for all the custom code processing the weight-at-age and age-to-length-conversion inputs. The match with the SS3 isn't perfect, but it's pretty good and I think worth having the stock visible on the rendered github.io page.How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?