Add air as styling option#865
Draft
k-doering-NOAA wants to merge 13 commits into
Draft
Conversation
Contributor
|
Thanks for this PR @k-doering-NOAA. I approve it but I am going to wait to merge it in until we do a release that way all of the files are committed and we do not have a lot of outstanding branches out there that would need to be rebased when the styler is run. |
cfe6ab9 to
4454859
Compare
f362d4a to
638ee30
Compare
4a24251 to
51adea8
Compare
db3ddf7 to
e0be2a1
Compare
afee2ed to
1276b24
Compare
4c488fc to
b3d15a2
Compare
* Initial plan * Update doxygen documentation link to new location Co-authored-by: kellijohnson-NOAA <4108564+kellijohnson-NOAA@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kellijohnson-NOAA <4108564+kellijohnson-NOAA@users.noreply.github.com>
…eys to log_M for rows_update compatibility. Updated test snapshot.
* Removes FIMS Developer Handbook link from pkgdown site * Removes set_methods functions from Package development reference section, S4 methods with @Keywords internal to fix pkgdown build * Improve pkgdown configuration descriptions and cleanup comments Co-authored-by: kellijohnson-NOAA <4108564+kellijohnson-NOAA@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5 to 6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v5...v6) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7 to 8. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v7...v8) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Also assigns FIMS Project lead to the Pull Request, where the Project Lead is a designated Team on NOAA-FIMS Teams so it only has to be changed in one location when there is changeover.
The action writes to a Pull Request and needs this permission instead of content
b3d15a2 to
343c111
Compare
Co-authored-by: kellijohnson-NOAA <4108564+kellijohnson-NOAA@users.noreply.github.com>
Co-authored-by: kellijohnson-NOAA <4108564+kellijohnson-NOAA@users.noreply.github.com>
Co-authored-by: kellijohnson-NOAA <4108564+kellijohnson-NOAA@users.noreply.github.com>
Thanks to Bai for the suggestion
2b4b7e0 to
eb8f044
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
===========================================
+ Coverage 70.58% 85.97% +15.38%
===========================================
Files 52 81 +29
Lines 1914 7893 +5979
Branches 512 510 -2
===========================================
+ Hits 1351 6786 +5435
- Misses 496 1096 +600
+ Partials 67 11 -56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3bf9e4f to
de9a41e
Compare
87a3229 to
e1f5808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?