Skip to content

chore: Removes all contributors content from readme#1551

Merged
kellijohnson-NOAA merged 1 commit into
mainfrom
chore-remove-allcontributors
Jun 19, 2026
Merged

chore: Removes all contributors content from readme#1551
kellijohnson-NOAA merged 1 commit into
mainfrom
chore-remove-allcontributors

Conversation

@kellijohnson-NOAA

@kellijohnson-NOAA kellijohnson-NOAA commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

What is the feature?

  • Remove the list of all contributors from the README because we have the same list on our website and users can go to the insights to see who has committed.

How have you implemented the solution?

  • Remove the workflow and remove the section from the README.
  • Removed authors from vignettes so their names do not have to be stored
  • Removed GitHub handles and names from WORDLIST
  • Removed GitHub handles from a few comments

Does the PR impact any other area of the project, maybe another repo?

  • The spell check is currently failing on main, that failure will go away with this PR b/c the failures are due to names.

close #1375

@peterkuriyama-NOAA let me know if you do not have time to review this PR.


Instructions for code reviewer

👋Hello reviewer👋, thank you for taking the time to review this PR!

  • Please use this checklist during your review, checking off items that you have verified are complete but feel free to skip over items that are not relevant!
  • See the GitHub documentation for how to comment on a PR to indicate where you have questions or changes are needed before approving the PR.
  • Please use standard conventional messages for both commit messages and comments
  • PR reviews are a great way to learn so feel free to share your tips and tricks. However, when suggesting changes to the PR that are optional please include nit: (for nitpicking) as the comment type. For example, nit: I prefer using a data.frame() instead of a matrix because ...
  • Engage with the developer. Make it clear when the PR is approved by selecting the approved status, and potentially commenting on the PR with something like This PR is now ready to be merged.

Checklist

  • The code is well-designed
  • The code is designed well for both users and developers
  • Code coverage remains high- [ ] Comments are clear, useful, and explain why instead of what
  • Code is appropriately documented (doxygen and roxygen)

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.39%. Comparing base (9448266) to head (1311c2e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1551   +/-   ##
=======================================
  Coverage   87.39%   87.39%           
=======================================
  Files          97       97           
  Lines        8746     8746           
  Branches      519      520    +1     
=======================================
  Hits         7644     7644           
+ Misses       1065     1064    -1     
- Partials       37       38    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kellijohnson-NOAA kellijohnson-NOAA force-pushed the chore-remove-allcontributors branch from 328c805 to e8455ae Compare June 17, 2026 19:15
Comment thread inst/WORDLIST
Comment thread inst/WORDLIST
Comment thread inst/WORDLIST
Comment thread inst/WORDLIST

@peterkuriyama-NOAA peterkuriyama-NOAA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments in the inst/WORDLIST. I'm not sure what the function of this file is (maybe a kind of index?)

@kellijohnson-NOAA

Copy link
Copy Markdown
Contributor Author

Thank you Peter for the review. The WORDLIST file is used for cspell, which checks the spelling within certain files.

@kellijohnson-NOAA kellijohnson-NOAA force-pushed the chore-remove-allcontributors branch from a1c089c to 1311c2e Compare June 19, 2026 15:07
@kellijohnson-NOAA kellijohnson-NOAA merged commit 8f4f488 into main Jun 19, 2026
27 of 30 checks passed
@kellijohnson-NOAA kellijohnson-NOAA deleted the chore-remove-allcontributors branch June 19, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove allcontributors from README

2 participants