Dev dirchlet linear#1516
Open
msupernaw wants to merge 30 commits into
Open
Conversation
…l_tests_output.txt
Removed comment about using the FIMS custom sum function.
Removed unnecessary include for fims_vector.hpp.
…test inputs for DM PMF read from csv created and verified with "Test_value_diric_multinom.R"
Use the global lgamma (::lgamma) in ddiric_multinom to avoid incorrect fims_math resolution, and update calls accordingly. Add fims_math include to the Dirichlet-multinomial functor and export the functor header from distributions.hpp. Fix Rcpp distribution interface bugs and naming/initialization issues: correct make_shared/copy-constructor types for the DDirichletMultinomial interface, initialize the underlying theta from initial_value_m, and update Rcpp bindings (method names, fields and expose theta). These changes address compilation/runtime errors and ensure the Dirichlet-multinomial distribution is properly registered and usable from R.
Export DDirichletMultinomDistribution in NAMESPACE to make the new distribution available to package users. Also add DDirichletMultinomialDistributionsInterface to inst/WORDLIST so the identifier is recognized by the package wordlist (avoids spellcheck/lint issues).
Added 'dirichlet_multinomial' to available distributions and created a new function for it.
… into dev-dirchlet-linear
Updated documentation @details to clarify the implementation of the Dirichlet-multinomial log-probability mass function.
… into dev-dirchlet-linear
Delete duplicate lines in @file
…roposed fix to switch between composition distribution types in "fix_helper_setup_R1.docx". More general solution recommended for multiple composition types and other submodel components.
…ration-tests-validation.R to support Dirichlet-Multinomial distribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?
Instructions for code reviewer
👋Hello reviewer👋, thank you for taking the time to review this PR!
nit:(for nitpicking) as the comment type. For example,nit:I prefer using adata.frame()instead of amatrixbecause ...This PR is now ready to be merged.Checklist