_ in type for data and change to data_big#1293
Merged
Merged
Conversation
6 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1293 +/- ##
==========================================
+ Coverage 86.87% 88.91% +2.04%
==========================================
Files 81 80 -1
Lines 7803 7923 +120
Branches 496 538 +42
==========================================
+ Hits 6779 7045 +266
+ Misses 1019 854 -165
- Partials 5 24 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awilnoaa
reviewed
Mar 12, 2026
awilnoaa
reviewed
Mar 12, 2026
awilnoaa
reviewed
Mar 12, 2026
awilnoaa
reviewed
Mar 12, 2026
Renames data1 to data_big and adds fims_input_types
23579a1 to
a081f58
Compare
Use plot of data in the fims-demo
* scales is not used anywhere * Adds alt text for the logo in the pkgdown site
a081f58 to
72722eb
Compare
kellijohnson-NOAA
added a commit
that referenced
this pull request
Mar 13, 2026
The following changes were made to data1, which is now named data_big. * Changes to "-" to "_" for type in FIMSFrame * Renames data1 to data_big and adds fims_input_types * Fix cli output to naturally create a list * Adds tests and logic checks for FIMSFrame * fix: use the stored fims_input_types object for validating * chore: Ignores usethis R functions from codecoverage * fix(plot(FIMSFrame)): Use tibble instead of S4 object * Use plot of data in the fims-demo * fix package loading errors * scales is not used anywhere so remove from DESCRIPTION * Adds alt text for the logo in the pkgdown site * Adds test for age or length compositions that do not sum to one for a given grouping
kellijohnson-NOAA
added a commit
that referenced
this pull request
Mar 16, 2026
The following changes were made to data1, which is now named data_big. * Changes to "-" to "_" for type in FIMSFrame * Renames data1 to data_big and adds fims_input_types * Fix cli output to naturally create a list * Adds tests and logic checks for FIMSFrame * fix: use the stored fims_input_types object for validating * chore: Ignores usethis R functions from codecoverage * fix(plot(FIMSFrame)): Use tibble instead of S4 object * Use plot of data in the fims-demo * fix package loading errors * scales is not used anywhere so remove from DESCRIPTION * Adds alt text for the logo in the pkgdown site * Adds test for age or length compositions that do not sum to one for a given grouping
e-perl-NOAA
pushed a commit
to e-perl-NOAA/FIMS
that referenced
this pull request
Apr 13, 2026
The following changes were made to data1, which is now named data_big. * Changes to "-" to "_" for type in FIMSFrame * Renames data1 to data_big and adds fims_input_types * Fix cli output to naturally create a list * Adds tests and logic checks for FIMSFrame * fix: use the stored fims_input_types object for validating * chore: Ignores usethis R functions from codecoverage * fix(plot(FIMSFrame)): Use tibble instead of S4 object * Use plot of data in the fims-demo * fix package loading errors * scales is not used anywhere so remove from DESCRIPTION * Adds alt text for the logo in the pkgdown site * Adds test for age or length compositions that do not sum to one for a given grouping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the feature?
Does the PR impact any other area of the project, maybe another repo?
Close #1247
Instructions for code reviewer
Hello reviewer, thanks for taking the time to review this PR!
nit:(for nitpicking) as the comment type. For example,nit:I prefer using adata.frame()instead of amatrixbecause ...This PR is now ready to be merged, no additional changes are needed.Checklist