fixes data1#1006
Merged
Bai-Li-NOAA merged 2 commits intoOct 2, 2025
Merged
Conversation
Contributor
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the data structure by replacing date-based timing with numeric timing values. It changes from using datestart and dateend columns to a single timing column that represents years as numeric values, enabling future support for fractional year resolution while currently restricting to integer values.
- Replaced date columns (
datestart,dateend) with single numerictimingcolumn - Updated validation logic to check for numeric timing instead of date format validation
- Modified data generation and processing functions to use numeric years directly
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| inst/WORDLIST | Removed dateend and datestart entries, added timing and timings |
| data-raw/data1.R | Replaced date creation logic with direct year assignment from timing column |
| R/initialize_modules.R | Updated global variables and column references from date columns to timing |
| R/fimsframe.R | Refactored validation, plotting, and data processing to use numeric timing instead of dates |
| R/data1.R | Updated documentation to reflect new timing column structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c6acadb to
3a8beb0
Compare
- add get_finalized_fims to FIMSFit class - add finalized_fims slot to FIMSFit class - add a test for get_finalized_fims() - add a test for reshape_json_estimates() to address issue #898 - update -999 or NA to null for JSON output since JSON has a dedicated literal for missing values. The {jsonlite} package will automatically convert null in JSON to NA in R.
- We will be using timing from now on instead of date where timing is a double which allows for the year to be incremented using whatever resolution you input. Right now, the only resolution that is available in FIMS is year so timing must be an integer value. - fix(fimsframe): Fixes bug in FIMSFrame validators Co-authored-by: Dr. Wilson <awilnoaa@users.noreply.github.com> Co-authored-by: alexjensen-NOAA <alexjensen-NOAA@users.noreply.github.com>
ff1f945 to
428a543
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will be using timing from now on instead of date where timing is a double which allows for the year to be incremented using whatever resolution you input. Right now, the only resolution that is available in FIMS is year so timing must be an integer value.
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?
Part of #982
@Bai-Li-NOAA I have listed you as a reviewer because I would like to merge this into your PR that goes into dev-json-caa and then eventually dev.