Picky correctness improvement to inline TOML comment in policy template.#442
Open
Picky correctness improvement to inline TOML comment in policy template.#442
Conversation
`send-notify-to` requires quoted `IP:[port]` values but the TOML doc doesn't mention the quotes, and unlike the server address binding examples in the main config file, here there is no default value making the syntax self-documenting. It also says a collection while strictly speaking it should be a set, and to be even more pedantic I noted that it should be comma-separated.
bal-e
reviewed
Feb 2, 2026
Contributor
bal-e
left a comment
bal-e
left a comment
There was a problem hiding this comment.
I agree that the comment should be more descriptive, but I'm worried about the phrase "comma-separated". For anybody who is familiar with TOML, "comma-separated" can also cause confusion. Perhaps we should just provides some concrete examples (while also adding quotations around "IP:[port]")?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send-notify-torequires quotedIP:[port]values but the TOML doc doesn't mention the quotes, and unlike the server address binding examples in the main config file, here there is no default value making the syntax self-documenting. It also says a collection while strictly speaking it should be a set, and to be even more pedantic I noted that it should be comma-separated.