Strip NSEC3PARAM from the input zone before signing. (resolves #407)#408
Draft
Strip NSEC3PARAM from the input zone before signing. (resolves #407)#408
Conversation
…3PARAM fails when signed with an NSEC policy, because the NSEC3PARAM is wrongly left in the zone.
Member
Author
|
This PR needs #401 to be merged first, as that solves the cause of the integration test failure in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR that adds an integration test that shows the problem.
Will make it ready to review once the issue is fixed.
Test run: https://github.com/NLnetLabs/cascade/actions/runs/20167569969