Skip to content

reg controller winding field#184

Merged
AadilLatif merged 1 commit into
mainfrom
zz/tap_winding
Jun 16, 2026
Merged

reg controller winding field#184
AadilLatif merged 1 commit into
mainfrom
zz/tap_winding

Conversation

@zzink-nrel

Copy link
Copy Markdown

Change Summary

Add a field to Regulator controllers to specify which winding is to be acted upon. If not specified, when converted to opendss, a default of 1 will take effect, which is often wrong.

Related issue number

Checklist

  • The pull request title is a good summary of the changes.
  • Tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including "please review" to assign reviewers

@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new data-model field to RegulatorController so consumers (e.g., OpenDSS export) can target which transformer winding a regulator controller acts on, avoiding incorrect implicit defaults during conversion.

Changes:

  • Introduces a tapped_winding field on RegulatorController with validation constraints and a description.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AadilLatif AadilLatif merged commit 8b21cd8 into main Jun 16, 2026
6 checks passed
@AadilLatif AadilLatif deleted the zz/tap_winding branch June 16, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants