Conversation
Data request 56: Scallop Restricted areas
Merge branch 'dev' of https://github.com/NEFSC/NEFSC-Spatial into check_cmd # Conflicts: # .Rbuildignore # DESCRIPTION
added a R-cmd-check workflow
…ation message to register with users
Massachusetts inshore survey strata
incorporate MDEB database
Consistent dimensions for Features in data documentation
…into doc_cleanup
Doc cleanup
Member
Author
|
@jmhatch so i think we have all of the dependent PRs documented in the description. Want to build and check? If happy can you merge and i'll then version the package. ps. I edited the NEWS.md to document package changes. This will be added to the release notes when versioned. Want to check to make sur it's ok, if not feel free to edit. We also may want to think about adding the news/changelog to the website as a navbar option. We could do it now or later. Either is ok with me |
Member
|
@andybeet! I built the pkg and pkgdown site, no errors. A cursory glance and everything looks good. I'll go ahead and merge it. And I like the addition of the NEWS.md to easily track changes. We can add it to the pkgdown site next go round, it'd be a nice addition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data
Functions
Restructure
Fixes
tools::checkRdaFiles(paths))