-
Notifications
You must be signed in to change notification settings - Fork 25
add CONTRIBUTING.md file (and contributing guidelines, of course) #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
=======================================
Coverage 76.83% 76.83%
=======================================
Files 15 15
Lines 2936 2936
Branches 467 467
=======================================
Hits 2256 2256
Misses 558 558
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bmaranville
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward to me - and I agree with the sentiments within.
|
I think this is pretty good too. I think you've got the key elements. |
|
This looks good. We can enhance this anytime in the future. Thanks @valeriupredoi |
|
spiffy, many thanks @bnlawrence and @kmuehlbauer 🍻 |
|
@valeriupredoi Please enable discussions in the repo-settings, since it's usage is suggested now in CONTRIBUTING.md. |
Many thanks! Cheers and beers ;-) |
|
@kmuehlbauer I believe they were enabled, just made sure they are proper now, cheers for the heads up 🍺 |
Description
Closes #177
This is something we should have added a bit ago - but got prompted via the JOSS paper review - and many thanks to @Zeitsperre for bringing it up in the review! I have started fleshing out the contributing guidelines, but I could use input from @bnlawrence and @davidhassell as in-house power devs, @kmuehlbauer as someone who contributed greatly but was external to the project in the beginning, and also perhaps from @bmaranville and @jjhelmus as long term, initial contributors (and initiators, for the matter) of the project. Many thanks in advance! 🍻
Before you get started
Checklist