Fix #919 - use host filter#920
Draft
lars-t-hansen wants to merge 7 commits into
Draft
Conversation
Collaborator
Author
|
This is a bit of a nightmare. The logical direction of part of this is an abstraction for "merged hostnames" (to get away from the string representation of that). But we already have one of those, it's the "Hostnames" structure used for partial name matching. But do we want to saddle that with additional duties? It is a fairly expensive data structure. |
lars-t-hansen
force-pushed
the
larstha-919-hosts
branch
from
68a4332 to
d6e4e02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the QueryFilter contain a Hosts instead of a node list. This introduces a number of sanity checks at various points and cleans up some config logic. It's a win for program logic though not necessarily for performance.
Currently it fails to pass
make regressbecause the host name of a merged job is not a single-host name necessarily, and the sanity checks catch that. It is probably a bug that was introduced with the rewrite of the config logic. It looks like it might take a little work to fix it.