ci(lab3): add PR gate#3
Open
Mysteri0K1ng wants to merge 9 commits into
Open
Conversation
Signed-off-by: Nikita Schankin <nikita.sshankin@gmail.com>
Signed-off-by: Nikita Schankin <nikita.sshankin@gmail.com>
Signed-off-by: Nikita Schankin <nikita.sshankin@gmail.com>
This reverts commit eea2590. Signed-off-by: Nikita Schankin <nikita.sshankin@gmail.com>
Signed-off-by: Nikita Schankin <nikita.sshankin@gmail.com>
Signed-off-by: Nikita Schankin <nikita.sshankin@gmail.com>
Signed-off-by: Nikita Schankin <nikita.sshankin@gmail.com>
Signed-off-by: Nikita Schankin <nikita.sshankin@gmail.com>
Signed-off-by: Nikita Schankin <nikita.sshankin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Add a PR-gated GitHub Actions pipeline for QuickNotes and document Lab 3 CI/CD results.
Changes
.github/workflows/ci.ymlwith separatevet,test, andlintjobsgolangci-lintversionsubmissions/lab3.mdTesting
Verified that the CI pipeline passes with
vet,test, andlintjobs. I also intentionally broke a test to confirm that CI fails and the PR is blocked, then reverted the breaking commit and confirmed the pipeline returned to green.Checklist
git log --show-signature)submissions/lab3.mdupdated